Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: llama3 tokenizer #64

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

omarkilani
Copy link

I'm not sure if the project wants to support non-OpenAI models, but just in case someone comes along and needs this, here you are. :)

Copy link
Owner

@zurawiki zurawiki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code LGTM, just make sure to add the public URL for the llama3 tokenizer here:

export ASSETS=$(cat <<EOF
https://openaipublic.blob.core.windows.net/gpt-2/encodings/main/vocab.bpe
https://openaipublic.blob.core.windows.net/gpt-2/encodings/main/encoder.json
https://openaipublic.blob.core.windows.net/encodings/r50k_base.tiktoken
https://openaipublic.blob.core.windows.net/encodings/p50k_base.tiktoken
https://openaipublic.blob.core.windows.net/encodings/cl100k_base.tiktoken
https://openaipublic.blob.core.windows.net/encodings/o200k_base.tiktoken
EOF
)

@omarkilani
Copy link
Author

@zurawiki there are updates for 3.1 and 3.2 that need to be pushed also.

Will extract it from our stuff soon.

Thanks!

@noppej
Copy link

noppej commented Dec 12, 2024

@zurawiki This will be a useful addition to make llama encodings accessible for Rust. @omarkilani ... thanks in advance for your contribution!

@noppej noppej mentioned this pull request Dec 12, 2024
@zurawiki
Copy link
Owner

Hi guys, I'm open to supporting the llama tokenizer and merging this PR but there are still two outstanding items here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants