Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md and add overlay option #58

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

moshfeu
Copy link

@moshfeu moshfeu commented Jun 28, 2016

README.md

  1. Add demo link.
  2. Fix images URLs in the examples

Plugin code

  1. Add the option overlay.
  2. Add some events and methods.
  3. Add the option min_offset

@moshfeu moshfeu changed the title Update README.md Update README.md and add overlay option Jun 28, 2016
moshfeu added 2 commits June 28, 2016 16:39
1. When you set "transition_in" to true, the handle will smoothly "go" to the point you set in "default_offset_pct".
2. When the plugin is ready it calls to "init.twentytwenty" so you can listen to this event.
3. You can call now to "goTo" function to with the percent you want the handle will go.
@raphaeleidus
Copy link
Contributor

Hey @moshfeu #72 introduced the same functionality for suppressing the overlay.

As for min_offset and the events and methods for programatic control that is interesting and I would like to see those introduced. This branch needs a bit of love before it can be merged. If you are still interested and want to touch up the branch let me know.
In the future, smaller PRs that introduce a single feature at a time would be better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants