Pin gtest version and update tests

- Pinned to latest commit hash as of today - Latest tag appears to be broken - Replace deprecated `INSTANTIATE_TEST_CASE_P` → `INSTANTIATE_TEST_SUITE_P`
zyantific · Jul 13, 2019 · e6420b3 · e6420b3
1 parent c270a94
commit e6420b3
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 4 deletions.
diff --git a/.gitignore b/.gitignore
@@ -95,4 +95,6 @@ msvc/**/bin/
 
 doc/html
 
-.vscode
+/.vscode
+/.idea
+/cmake-build-*
diff --git a/CMakeLists.txt.in b/CMakeLists.txt.in
@@ -5,7 +5,7 @@ project(googletest-download NONE)
 include(ExternalProject)
 ExternalProject_Add(googletest
   GIT_REPOSITORY    https://github.com/google/googletest.git
-  GIT_TAG           master
+  GIT_TAG           ee3aa831172090fd5442820f215cb04ab6062756
   SOURCE_DIR        "${CMAKE_BINARY_DIR}/gtest/src"
   BINARY_DIR        "${CMAKE_BINARY_DIR}/gtest/build"
   CONFIGURE_COMMAND ""

diff --git a/tests/Vector.cpp b/tests/Vector.cpp
@@ -484,8 +484,8 @@ TEST_P(VectorTestFilled, SwapElements)
     EXPECT_EQ(values_before[1], values_after[0]);
 }
 
-INSTANTIATE_TEST_CASE_P(Param, VectorTestBase, ::testing::Values(false, true));
-INSTANTIATE_TEST_CASE_P(Param, VectorTestFilled, ::testing::Values(false, true));
+INSTANTIATE_TEST_SUITE_P(Param, VectorTestBase, ::testing::Values(false, true));
+INSTANTIATE_TEST_SUITE_P(Param, VectorTestFilled, ::testing::Values(false, true));
 
 /* ---------------------------------------------------------------------------------------------- */