Skip to content

Commit

Permalink
Set version as release when there are no commits ahead (#3515)
Browse files Browse the repository at this point in the history
Print release version tag in tools/build-version.go even if the commit
being checked has a tag that is not a version number if there are no
commits ahead.
  • Loading branch information
niten94 authored Oct 22, 2024
1 parent 3cb8069 commit 2c6dc32
Showing 1 changed file with 6 additions and 7 deletions.
13 changes: 6 additions & 7 deletions tools/build-version.go
Original file line number Diff line number Diff line change
Expand Up @@ -47,15 +47,16 @@ func main() {
fmt.Println("0.0.0-unknown")
return
}
// Get the tag of the current revision.
tag, _ := getTag("--exact-match")
if tag == versionStr {
if ahead == nil {
// Seems that we are going to build a release.
// So the version number should already be correct.
fmt.Println(version.String())
return
}

// Get the tag of the current revision.
tag, _ := getTag("--exact-match")

// If we don't have any tag assume "dev"
if tag == "" || strings.HasPrefix(tag, "nightly") {
tag = "dev"
Expand All @@ -72,10 +73,8 @@ func main() {
log.Printf("semver.NewPRVersion(%s): %v", tag, err)
}

if ahead != nil {
// if we know how many commits we are ahead of the last release, append that too.
version.Pre = append(version.Pre, *ahead)
}
// append how many commits we are ahead of the last release
version.Pre = append(version.Pre, *ahead)

fmt.Println(version.String())
}

0 comments on commit 2c6dc32

Please sign in to comment.