Autocompletion of file paths in editor. #3586
Conversation
|
Hello maintainers, apart from actual code submitted, do you think the idea is worth pursuing? |
| func IsQuoteOrBraceStart(r rune) bool { | ||
| return r == '"' || r == '\'' || r == '(' || r == '[' || r == '{' | ||
| } |
There was a problem hiding this comment.
Functions like this are placed in internal/util/util.go.
| // Allow completion of paths inside quotes and braces | ||
| path_start := strings.LastIndexFunc(input, IsQuoteOrBraceStart) + 1 |
There was a problem hiding this comment.
I think supporting this is good, but it is unrelated with just adding a way to complete paths in editing. It would probably be better to do this change in another commit or mention in the commit description.
| // Complete filenames or buffer words | ||
| func Complete(b *Buffer) ([]string, []string) { | ||
| completions, suggestions := FileComplete(b) | ||
| if len(completions) != 0 || len(suggestions) != 0 { | ||
| return completions, suggestions | ||
| } | ||
| return BufferComplete(b) | ||
| } |
There was a problem hiding this comment.
It may be better to support completing paths using a different action (like CommandComplete?), then change the default binding of Tab to AutoComplete|FileComplete (Always trying to complete paths first somehow does not seem nice). It would be possible to change the order or remove one action if someone wanted to.
| package buffer | ||
|
|
||
| import ( | ||
| "io/ioutil" |
There was a problem hiding this comment.
io/ioutil is deprecated. It is still used in other parts of code in micro but there is an open pull request switching to other functions.
| files := []string{"file1.txt", "file2.txt"} | ||
|
|
||
| for _, subdir := range subdirs { | ||
| if err := os.Mkdir(dir+string(os.PathSeparator)+subdir, 0755); err != nil { |
There was a problem hiding this comment.
Use path/filepath.Join?
Please use gofmt with modified files too.
Change:
Add file completion as a default autocomplete option in edit mode (beside buffer complete).
Rationale:
Simple text editor like micro is great for editing bash scripts and config files. In such scenarios file path completion is very handy. Micro already has code for file completion but only in command mode.