feat: add helper function for sanity checking parameters #463
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There are some combinations of parameters within
input_parser.star
which can result in a successful deployment after runningkurtosis run .
, but may cause some services to fail after the deployment. An example of this would be:When running Kurtosis CDK with these parameters, the deployment will succeed, but the aggkit component will return an error, because the process of creating and attaching sovereign rollups and deploying sovereign contracts assumes a pessimistic consensus contract is supported.
This PR adds a helper function
sanity_check()
to check for these type of incompatible parameters at the start of the deployment and exits the deployment withfail()
if such cases are caught. A separate helper function was created with this in mind, because adding checks in the middle of the deployment would require the user to wait much longer than needed only to find out the deployment wouldn't work. In case more incompatible cases are found, it could be added to thesanity_check()
function to detect them early in the deployment.