Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add helper function for sanity checking parameters #463

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jhkimqd
Copy link
Collaborator

@jhkimqd jhkimqd commented Feb 5, 2025

Description

There are some combinations of parameters within input_parser.star which can result in a successful deployment after running kurtosis run ., but may cause some services to fail after the deployment. An example of this would be:

"deploy_optimism_rollup": True,
...
"consensus_contract_type": "cdk-validium",

When running Kurtosis CDK with these parameters, the deployment will succeed, but the aggkit component will return an error, because the process of creating and attaching sovereign rollups and deploying sovereign contracts assumes a pessimistic consensus contract is supported.

image

This PR adds a helper function sanity_check() to check for these type of incompatible parameters at the start of the deployment and exits the deployment with fail() if such cases are caught. A separate helper function was created with this in mind, because adding checks in the middle of the deployment would require the user to wait much longer than needed only to find out the deployment wouldn't work. In case more incompatible cases are found, it could be added to the sanity_check() function to detect them early in the deployment.

image

@jhkimqd jhkimqd force-pushed the jihwan/sanity-check branch from 43ff7a0 to 491cfed Compare February 5, 2025 02:47
Copy link

sonarqubecloud bot commented Feb 5, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant