Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add helper function for sanity checking parameters #463

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
+8 −0
Open

feat: add helper function for sanity checking parameters #463

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
491cfed
feat: add helper function for sanity checking parameters
jhkimqd Feb 5, 2025
2926e59
refactor: move op-stack check to input_parser.star
jhkimqd Feb 5, 2025
12044cd
Merge branch 'main' into jihwan/sanity-check
jhkimqd Feb 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions input_parser.star
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,8 @@ DEFAULT_DEPLOYMENT_STAGES = {
# TODO: Remove this parameter to incorporate cdk-erigon inside the central environment.
"deploy_cdk_erigon_node": True,
# Deploy Optimism rollup.
# Setting to True will deploy the Aggkit components and Sovereign contracts as well.
# Requires consensus_contract_type to be "pessimistic".
"deploy_optimism_rollup": False,
# Deploy contracts on L2 (as well as fund accounts).
"deploy_l2_contracts": False,
Expand Down Expand Up @@ -459,6 +461,12 @@ def parse_args(plan, user_args):

# Determine OP stack args.
op_stack_args = get_op_stack_args(plan, args, op_stack_args)
# deploy_optimistic_rollup and consensus_contract_type check
if deployment_stages.get("deploy_optimism_rollup", False):
if args.get("consensus_contract_type", "cdk-validium") != "pessimistic":
fail(
"OP Stack rollup requires pessimistic consensus contract type. Change the consensus_contract_type parameter"
)

# When using assertoor to test L1 scenarios, l1_preset should be mainnet for deposits and withdrawls to work.
if "assertoor" in args["l1_additional_services"]:
Expand Down
Loading