[TECH] Corriger le warning valid integer des tests d'intég
#11532
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yannbertrand
added
👀 Tech Review Needed
team-certif
cross-team
|
Une fois les applications déployées, elles seront accessibles via les liens suivants :
Les variables d'environnement seront accessibles via les liens suivants : |
alexandrecoin
approved these changes
Feb 28, 2025
aurelie-crouillebois
approved these changes
Feb 28, 2025
yannbertrand
added
Tech Review OK
🚀 Ready to Merge
and removed
👀 Tech Review Needed
labels
pix-service-auto-merge
force-pushed
the
fix-valid-integer-test-log-error
branch
from
bf4628d to
718fbd9
Compare
Steph0
approved these changes
Feb 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🥞 Problème
Dans l'appel de
knex.limit,undefinedn'est pas un integer et ça cause un log dans le test d'intégration correspondant :C'était déjà arrivé et corrigé dans #6747.
🥓 Proposition
Mettre une valeur par défaut à la limite. (la fonction est toujours appelée avec une limite hors test)
🧃 Remarques
Mini correction de JSDoc au passage.
😋 Pour tester
CI 🟢 et disparation du log dans les tests d'intég.