Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TECH] Corriger le warning valid integer des tests d'intég #11532

Merged
merged 2 commits into from
Feb 28, 2025
+2 −2
Merged

[TECH] Corriger le warning valid integer des tests d'intég #11532

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e08e304
fix(api): object parameter jsdoc
yannbertrand Feb 27, 2025
718fbd9
fix(api): add a default limit to avoid errors
yannbertrand Feb 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions api/src/certification/configuration/infrastructure/repositories/candidate-repository.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,10 @@ import { Candidate } from '../../domain/models/Candidate.js';
* This function find candidates with a certification-course but no reconciledAt
*
* @param {Object} params
* @param {number} params.[limit] - number of candidates to limit to
* @param {number} [params.limit] - number of candidates to limit to
* @returns {Array<Candidate>} - Candidates returned have a reconciledAt built from certification-course
*/
export const findCandidateWithoutReconciledAt = async function ({ limit } = {}) {
export const findCandidateWithoutReconciledAt = async function ({ limit } = { limit: 1 }) {
const knexConn = DomainTransaction.getConnection();
const data = await knexConn('certification-candidates')
.select('certification-candidates.id', 'certification-courses.createdAt')
Expand Down