Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Command queue #119

Merged
merged 5 commits into from
Dec 18, 2023
Merged

feat: Command queue #119

merged 5 commits into from
Dec 18, 2023

Conversation

AMythicDev
Copy link
Owner

Many Commands is minus require additional operations to be done after their main objective have been completed. One example of this would be something like the Search command which after executing successfully also requires a update of the prompt to show the search match count. Currently all such commands directly use the functions handling these operations which makes the code look more confusing as well as introduces code duplication.

To solve this issue, a new type called CommandQueue is being introduced so that eachCcommand can issue other Commands to be executed once its main objective is finished executing.

Although the implementation of this new type is mostly complete, we need to port all the Commands that require such cases to use this new type

@AMythicDev AMythicDev marked this pull request as ready for review December 18, 2023 19:59
@AMythicDev AMythicDev merged commit 91cdd3f into main Dec 18, 2023
6 checks passed
@AMythicDev AMythicDev deleted the feat/command-queue branch December 20, 2023 20:50
@AMythicDev AMythicDev added the I-api Internal API change label Dec 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I-api Internal API change
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant