-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge branch-PPP-Marcus with Master #16
Merge branch-PPP-Marcus with Master #16
Conversation
Codecov ReportBase: 72.15% // Head: 72.15% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #16 +/- ##
=========================================
Coverage 72.15% 72.15%
Complexity 399 399
=========================================
Files 70 70
Lines 1232 1232
Branches 125 125
=========================================
Hits 889 889
Misses 311 311
Partials 32 32 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
title: Ong Wee Marcus's Project Portfolio Page | ||
--- | ||
|
||
### Project: Duke The Market |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we calling it Duke-The-Market?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's settle on "Duke The Market" as we have previously submitted that as the name of our product. Our product name has also been set and can be seen on the CS2103 website
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, though there may be some places with the incorrect name "Duke-The-Market" which we need to change.
E.g. The PR from our team repo to the upstream CS2103 repo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup, thanks for pointing that out. So far besides the PR, I haven't noticed anywhere else that uses "Duke-The-Market" yet. In the meantime, I have changed the title of the PR to "Duke The Market"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 👍
No description provided.