Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge branch-PPP-Marcus with Master #16

Merged

Conversation

lfrostbytee
Copy link

No description provided.

@lfrostbytee lfrostbytee added the type.Documentation Improvements or additions to documentation label Sep 23, 2022
@lfrostbytee lfrostbytee added this to the v1.1 milestone Sep 23, 2022
@lfrostbytee lfrostbytee requested a review from a team September 23, 2022 03:28
@lfrostbytee lfrostbytee self-assigned this Sep 23, 2022
@codecov-commenter
Copy link

Codecov Report

Base: 72.15% // Head: 72.15% // No change to project coverage 👍

Coverage data is based on head (7536121) compared to base (0be3d6e).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff            @@
##             master      #16   +/-   ##
=========================================
  Coverage     72.15%   72.15%           
  Complexity      399      399           
=========================================
  Files            70       70           
  Lines          1232     1232           
  Branches        125      125           
=========================================
  Hits            889      889           
  Misses          311      311           
  Partials         32       32           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@lfrostbytee lfrostbytee linked an issue Sep 23, 2022 that may be closed by this pull request
title: Ong Wee Marcus's Project Portfolio Page
---

### Project: Duke The Market

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we calling it Duke-The-Market?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's settle on "Duke The Market" as we have previously submitted that as the name of our product. Our product name has also been set and can be seen on the CS2103 website

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, though there may be some places with the incorrect name "Duke-The-Market" which we need to change.
E.g. The PR from our team repo to the upstream CS2103 repo.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, thanks for pointing that out. So far besides the PR, I haven't noticed anywhere else that uses "Duke-The-Market" yet. In the meantime, I have changed the title of the PR to "Duke The Market"

Copy link

@Benjamin-Sim Benjamin-Sim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@Benjamin-Sim Benjamin-Sim merged commit 53d4f60 into AY2223S1-CS2103-F09-2:master Sep 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type.Documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create individual Project Portfolio Pages
3 participants