forked from nus-cs2103-AY2223S1/tp
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge branch-PPP-Marcus with Master #16
Merged
Benjamin-Sim
merged 1 commit into
AY2223S1-CS2103-F09-2:master
from
lfrostbytee:branch-PPP-Marcus
Sep 24, 2022
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,32 @@ | ||
--- | ||
layout: page | ||
title: Ong Wee Marcus's Project Portfolio Page | ||
--- | ||
|
||
### Project: Duke The Market | ||
|
||
Duke The Market is a desktop contact management system application | ||
used for managing customer contacts in department stores. The user interacts with it using a CLI, | ||
and it has a GUI created with JavaFX. It is written in Java, and has about 10 kLoC. | ||
|
||
Given below are my contributions to the project. | ||
|
||
* **Code contributed**: to be added soon | ||
|
||
* **Enhancements implemented**: | ||
* to be added soon | ||
|
||
* **Documentation**: | ||
* Contributions to the User Guide: | ||
* to be added soon | ||
* Contributions to the Developer Guide: | ||
* to be added soon | ||
|
||
* **Contributions to team-based tasks**: | ||
* to be added soon | ||
|
||
* **Community**: | ||
* Review/Mentoring contributions: | ||
* to be added soon | ||
* Contributions beyond the project team: | ||
* to be added soon |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we calling it Duke-The-Market?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's settle on "Duke The Market" as we have previously submitted that as the name of our product. Our product name has also been set and can be seen on the CS2103 website
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, though there may be some places with the incorrect name "Duke-The-Market" which we need to change.
E.g. The PR from our team repo to the upstream CS2103 repo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup, thanks for pointing that out. So far besides the PR, I haven't noticed anywhere else that uses "Duke-The-Market" yet. In the meantime, I have changed the title of the PR to "Duke The Market"