Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/119 add ability to define rls from which to detect changes #121

Merged
merged 8 commits into from
Dec 9, 2024
Merged

Feature/119 add ability to define rls from which to detect changes #121

merged 8 commits into from
Dec 9, 2024

Conversation

miroslavpojer
Copy link
Collaborator

@miroslavpojer miroslavpojer commented Dec 3, 2024 •
edited
Loading

Release Notes:

  • Implemented new input to define from the tag.
  • Newly user can control start point for Release Notes generation.
  • Applied in project's yml files.

Closes #119
Closes #87

@miroslavpojer
#119 - Add ability to define RLS from which to detect changes
0d5fafe 
- Implemented new inpout to define from tag.
- Newly user is able to control start point for Release Notes generation.
@miroslavpojer
- Black tool applied.
940fc2b 
- Several pylint fixes.
@miroslavpojer miroslavpojer self-assigned this Dec 3, 2024
@miroslavpojer miroslavpojer marked this pull request as draft December 3, 2024 07:40
@miroslavpojer
- New version-tag-check version used.
7fa21b1 
- Applied to project's release draft yaml file.
@miroslavpojer miroslavpojer marked this pull request as ready for review December 4, 2024 11:44
dk1844
dk1844 approved these changes Dec 5, 2024
View reviewed changes
Copy link

@dk1844 dk1844 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (just posted a reword suggestion and a question)

.github/workflows/release_draft.yml Outdated Show resolved Hide resolved
examples/release_draft.yml Outdated Show resolved Hide resolved
release_notes_generator/generator.py Show resolved Hide resolved
@miroslavpojer miroslavpojer requested a review from dk1844 December 5, 2024 12:18
MobiTikula
MobiTikula reviewed Dec 9, 2024
View reviewed changes
Copy link
Collaborator

@MobiTikula MobiTikula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please react to my comments.

release_notes_generator/builder.py Show resolved Hide resolved
release_notes_generator/generator.py Outdated Show resolved Hide resolved
release_notes_generator/generator.py Outdated Show resolved Hide resolved
release_notes_generator/generator.py Outdated Show resolved Hide resolved
tests/test_action_inputs.py Show resolved Hide resolved
release_notes_generator/utils/pull_reuqest_utils.py Show resolved Hide resolved
tests/test_release_notes_generator.py Show resolved Hide resolved
@MobiTikula MobiTikula mentioned this pull request Dec 9, 2024
Merged
@miroslavpojer miroslavpojer merged commit 7a51e9f into master Dec 9, 2024
4 checks passed
@miroslavpojer miroslavpojer deleted the feature/119-Add-ability-to-define-RLS-from-which-to-detect-changes branch December 9, 2024 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dk1844 dk1844 dk1844 approved these changes

@Zejnilovic Zejnilovic Awaiting requested review from Zejnilovic Zejnilovic is a code owner

@benedeki benedeki Awaiting requested review from benedeki

@MobiTikula MobiTikula Awaiting requested review from MobiTikula

Assignees

@miroslavpojer miroslavpojer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add ability to define RLS from which to detect changes Previous release tag check orders by date
3 participants
@miroslavpojer @dk1844 @MobiTikula