Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alex #7

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 23 additions & 5 deletions lib/max_subarray.rb
Original file line number Diff line number Diff line change
@@ -1,8 +1,26 @@

# Time Complexity: ?
# Space Complexity: ?
# Time Complexity: O(n) where n is the length of nums
# Space Complexity: O(1)
def max_sub_array(nums)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

return 0 if nums == nil

raise NotImplementedError, "Method not implemented yet!"
return nil if nums.length == 0

max = nums[0]
current_count = 0

i = 0
while i < nums.length
current_count += nums[i]

if current_count > max
max = current_count
end

if current_count < 0
current_count = 0
end

i += 1
end

return max
end
31 changes: 27 additions & 4 deletions lib/newman_conway.rb
Original file line number Diff line number Diff line change
@@ -1,7 +1,30 @@


# Time complexity: ?
# Space Complexity: ?
# Time complexity: O(n) where n is the size of num
# Space Complexity: O(n) bc I am making an array dependent on size of num, n

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

def newman_conway(num)
raise NotImplementedError, "newman_conway isn't implemented"
end
if num == 0
raise ArgumentError, "Invalid, you can't use 0!"
elsif num == 1
return "1"
elsif num == 2
return "1 1"
end

p = Array.new(num)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just note, p isn't exactly a meaning ful variable name, although I recognize it is from the formula.

p[0] = nil
p[1] = 1
p[2] = 1

sequence = "1 1"

i = 3
while i <= num
p[i] = p[p[i - 1]] + p[i - p[i - 1]]
sequence += " #{p[i]}"

i += 1
end

return sequence
end
2 changes: 1 addition & 1 deletion test/max_sub_array_test.rb
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
require_relative "test_helper"

xdescribe "max subarray" do
describe "max subarray" do
it "will work for [-2,1,-3,4,-1,2,1,-5,4]" do
# Arrange
input = [-2,1,-3,4,-1,2,1,-5,4]
Expand Down