Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Earth - Emily #27

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Earth - Emily #27

wants to merge 4 commits into from

Conversation

emirry
Copy link

@emirry emirry commented Dec 14, 2020

Linked List Comprehension Questions

Question Response
1. What advantages does a LinkedList have over an Array? Linked lists are great to use if the size of the list doesn't matter. It's also faster to remove/delete data when order doesn't matter.
2. When is an Array more advantageous? When we're looking for a value.
3. What questions do you have about linked lists?

Copy link

@CheezItMan CheezItMan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done Emily, you hit the learning goals here. Well done.

Comment on lines +11 to 13
# Time complexity - O(1)
# Space complexity - O(1)
def add_first(data)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Comment on lines +23 to 25
# Time complexity - O(1)
# Space complexity - O(1)
def get_first

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Comment on lines +34 to 36
# Time complexity - O(1)
# Space complexity - O(1)
def length

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How is the time complexity O(1)? You have a loop.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah! yes, i changed this and just forgot to resubmit. it would be O(n)


def initialize
@head = nil
@tail = tail

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice having a tail pointer

Comment on lines +49 to 51
# Time complexity - O(1)
# Space complexity - O(1)
def add_last(data)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Comment on lines +58 to 60
# Time complexity - O(1)
# Space complexity - O(1)
def get_last

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Comment on lines +68 to 70
# Time complexity - O(n)
# Space complexity - O(n)
def get_at_index(index)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 , but what if length < index

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants