Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Earth - Emily #27

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
66 changes: 52 additions & 14 deletions lib/linked_list.rb
Original file line number Diff line number Diff line change
@@ -1,45 +1,83 @@
require_relative 'node'

class LinkedList
attr_reader :head
attr_reader :head, :tail

def initialize
@head = nil
@tail = tail

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice having a tail pointer

end

# Time complexity - ?
# Space complexity - ?
# Time complexity - O(1)
# Space complexity - O(1)
def add_first(data)
Comment on lines +11 to 13

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

first = Node.new(data)

if @head
first.next = @head
end

@head = first
end

# Time complexity - ?
# Space complexity - ?
# Time complexity - O(1)
# Space complexity - O(1)
def get_first
Comment on lines +23 to 25

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

if @head.nil?
return nil
end

return @head.data

end

# Time complexity - ?
# Space complexity - ?
# Time complexity - O(1)
# Space complexity - O(1)
def length
Comment on lines +34 to 36

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How is the time complexity O(1)? You have a loop.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah! yes, i changed this and just forgot to resubmit. it would be O(n)

return 0
count = 0
current = @head

while current != nil
count += 1
current = current.next
end

return count

end

# Time complexity - ?
# Space complexity - ?
# Time complexity - O(1)
# Space complexity - O(1)
def add_last(data)
Comment on lines +49 to 51

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

last = Node.new(data)

@tail ? @tail.next = last : @head = last
@tail = last
end

# Time complexity - ?
# Space complexity - ?
# Time complexity - O(1)
# Space complexity - O(1)
def get_last
Comment on lines +58 to 60

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

if @tail.nil?
return nil
end

return @tail.data
end

# Time complexity - ?
# Space complexity - ?
# Time complexity - O(n)
# Space complexity - O(n)
def get_at_index(index)
Comment on lines +68 to 70

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 , but what if length < index

return @head.data if index.zero?
current_index = 0
current = @head

until current.nil?
current = current.next
current_index += 1

return current.data if current_index == index
end
return nil
end
end
8 changes: 4 additions & 4 deletions test/linked_list_test.rb
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
end
end

xdescribe 'add_first & get_first' do
describe 'add_first & get_first' do
it 'can add values to an empty list' do
# Act
@list.add_first(3)
Expand Down Expand Up @@ -51,7 +51,7 @@
end
end

xdescribe "length" do
describe "length" do
it "will return 0 for an empty list" do
expect(@list.length).must_equal 0
end
Expand All @@ -66,7 +66,7 @@
end
end

xdescribe "addLast & getLast" do
describe "addLast & getLast" do
it "will add to the front if the list is empty" do
@list.add_last(1)
expect(@list.get_first).must_equal 1
Expand All @@ -93,7 +93,7 @@
end
end

xdescribe 'get_at_index' do
describe 'get_at_index' do
it 'returns nil if the index is outside the bounds of the list' do
expect(@list.get_at_index(3)).must_be_nil
end
Expand Down