test vaults and reserve indexing #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rabi-siddique
changed the base branch from
main
to
rs-automate-liquidation-testing
rabi-siddique
force-pushed
the
rs-vault-testing
branch
19 times, most recently
from
954545d to
c591541
Compare
rabi-siddique
changed the title
rabi-siddique
force-pushed
the
rs-vault-testing
branch
6 times, most recently
from
d63b5ee to
5f95b40
Compare
rabi-siddique
force-pushed
the
rs-vault-testing
branch
from
ef43862 to
04c2250
Compare
rabi-siddique
commented
Dec 19, 2024
|
|
||
| - name: Wait for GraphQL server | ||
| run: sleep 120 | ||
|
|
There was a problem hiding this comment.
For a lesser waiting period it tends to fail:
./scripts/validateData.mjs
API URL set to: http://localhost:3000/
Entity: vaults, Block Height: 742
Error: (TypeError#1)
TypeError#1: fetch failed
at Function.captureStackTrace (file:///home/runner/work/agoric-subql/agoric-subql/node_modules/ses/src/error/tame-v8-error-constructor.js:229:9)
at node:internal/deps/undici/undici:12618:11
at async file:///home/runner/work/agoric-subql/agoric-subql/scripts/validateData.mjs:24:20
TypeError#1 cause: (SocketError#2)
Nested error under TypeError#1
SocketError#2: other side closed
at Socket.onSocketEnd (node:internal/deps/undici/undici:9169:26)
at Socket.emit (node:events:529:35)
at endReadableNT (node:internal/streams/readable:1400:12)
at process.processTicksAndRejections (node:internal/process/task_queues:82:21)
At 60 seconds wait, http://localhost:3000 consistently works and test pass.
There was a problem hiding this comment.
Helpful to include a comment with what value you've found to be too small
Alternately, scripts/validateData.mjs could have a "wait and retry" but this is fine
There was a problem hiding this comment.
@rabi-siddique I agree with Turadg's wait and retry suggestion. Such hardcoded sleep times cause flakiness in future. Something like following can be done (as a follow-up)
- name: Wait for GraphQL server to be ready
run: |
echo "Waiting for GraphQL server to be ready..."
until curl -s -o /dev/null -w "%{http_code}" http://localhost:4000/graphql | grep -q "200"; do
echo "GraphQL server is not ready yet. Retrying in 5 seconds..."
sleep 5
done
echo "GraphQL server is ready!"
shell: bash
6831fd7 to
f923a69
Compare
rabi-siddique
force-pushed
the
rs-test
branch
from
c912d4f to
6a69b4e
Compare
rabi-siddique
force-pushed
the
rs-vault-testing
branch
5 times, most recently
from
773091e to
4ae66aa
Compare
turadg
reviewed
Dec 20, 2024
Comment on lines
40
to
42
| - name: Set Execute Permission for All Scripts | ||
| run: chmod +x ./scripts/*.mjs | ||
|
|
There was a problem hiding this comment.
this should be done in SCM. Git maintains the execution flags.
Suggested change
| - name: Set Execute Permission for All Scripts | |
| run: chmod +x ./scripts/*.mjs |
|
|
||
| - name: Wait for GraphQL server | ||
| run: sleep 120 | ||
|
|
There was a problem hiding this comment.
Helpful to include a comment with what value you've found to be too small
Alternately, scripts/validateData.mjs could have a "wait and retry" but this is fine
Comment on lines
50
to
51
| blockHeight: 1212 | ||
| apiUrl: 'http://localhost:3000/' |
There was a problem hiding this comment.
please move these repeated env vars to the job level
rabi-siddique
force-pushed
the
rs-vault-testing
branch
2 times, most recently
from
bf1abec to
acbb7ed
Compare
rabi-siddique
force-pushed
the
rs-vault-testing
branch
from
acbb7ed to
ff58074
Compare
frazarshad
approved these changes
Dec 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR automates the testing of Vault and Reserve entities using GraphQL queries to enhance flexibility in matching expected values. It also removes the test cases previously written with
@subql/testing, which were restrictive due to issues with dates.