-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test vaults and reserve indexing #38
Merged
+312
−119
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,79 @@ | ||
name: Vaults and Reserve Indexing | ||
on: | ||
pull_request: | ||
|
||
jobs: | ||
test: | ||
runs-on: ubuntu-latest | ||
steps: | ||
- uses: actions/checkout@v4 | ||
|
||
- name: Start A3P container | ||
run: docker compose --profile ci up -d a3p | ||
|
||
- run: corepack enable | ||
shell: bash | ||
|
||
- name: Setup Node.js environment | ||
uses: actions/setup-node@v4 | ||
with: | ||
node-version: 18 | ||
cache: yarn | ||
|
||
- name: Install dependencies | ||
run: yarn install | ||
|
||
- name: Start subql indexer | ||
env: | ||
AGORIC_NET: ci | ||
run: yarn dev | ||
|
||
- name: Print initial logs of all containers | ||
run: | | ||
echo "Fetching initial logs for all containers..." | ||
containers=$(docker ps --format '{{.ID}}') | ||
for container in $containers; do | ||
echo "Fetching initial logs for container $container..." | ||
docker logs $container | ||
done | ||
|
||
# We tried delays of 10, 20, and 30 seconds, but a 60-second delay is the most efficient | ||
# and ensures that the server is fully ready, without causing any issues. | ||
- name: Wait for GraphQL server | ||
run: sleep 60 | ||
|
||
- name: Test VaultManagerGovernance | ||
run: ./scripts/validateData.mjs | ||
env: | ||
entity: vaultManagerGovernances | ||
blockHeight: 1212 | ||
|
||
- name: Test VaultManagerMetrics | ||
run: ./scripts/validateData.mjs | ||
env: | ||
entity: vaultManagerMetrics | ||
blockHeight: 1212 | ||
|
||
- name: Test VaultManagerMetricsDaily | ||
run: ./scripts/validateData.mjs | ||
env: | ||
entity: vaultManagerMetricsDailies | ||
blockHeight: 1212 | ||
|
||
- name: Test ReserveMetrics | ||
run: ./scripts/validateData.mjs | ||
env: | ||
entity: reserveMetrics | ||
blockHeight: 1212 | ||
|
||
- name: Test ReserveAllocationMetrics | ||
run: ./scripts/validateData.mjs | ||
env: | ||
entity: reserveAllocationMetrics | ||
blockHeight: 1212 | ||
|
||
- name: Test ReserveAllocationMetricsDaily | ||
run: ./scripts/validateData.mjs | ||
env: | ||
entity: reserveAllocationMetricsDailies | ||
blockHeight: 1212 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Empty file.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Empty file.
Empty file.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,187 @@ | ||
const buildFilter = (filters) => { | ||
const filterStrings = Object.entries(filters).map(([key, value]) => { | ||
return `${key}: {equalTo: "${value}"}`; | ||
}); | ||
return `(filter: {${filterStrings.join(', ')}})`; | ||
}; | ||
|
||
export const getQuery = (entity, filters) => { | ||
const filterString = buildFilter(filters); | ||
|
||
const queries = { | ||
vaultManagerGovernances: `query { | ||
vaultManagerGovernances ${filterString} { | ||
nodes { | ||
id | ||
debtLimit | ||
interestRateDenominator | ||
interestRateNumerator | ||
liquidationMarginDenominator | ||
liquidationMarginNumerator | ||
liquidationPaddingDenominator | ||
liquidationPaddingNumerator | ||
liquidationPenaltyDenominator | ||
liquidationPenaltyNumerator | ||
mintFeeDenominator | ||
mintFeeNumerator | ||
} | ||
} | ||
}`, | ||
vaultManagerMetrics: `query { | ||
vaultManagerMetrics ${filterString} { | ||
nodes { | ||
id | ||
liquidatingCollateralBrand | ||
liquidatingCollateralValue | ||
liquidatingDebtBrand | ||
liquidatingDebtValue | ||
lockedQuoteDenominator | ||
lockedQuoteNumerator | ||
numActiveVaults | ||
numLiquidatingVaults | ||
numLiquidationsAborted | ||
numLiquidationsCompleted | ||
retainedCollateral | ||
totalCollateral | ||
totalCollateralSold | ||
totalDebt | ||
totalOverageReceived | ||
totalProceedsReceived | ||
totalShortfallReceived | ||
} | ||
} | ||
}`, | ||
vaultManagerMetricsDailies: `query { | ||
vaultManagerMetricsDailies ${filterString} { | ||
nodes { | ||
path | ||
liquidatingCollateralBrand | ||
liquidatingDebtBrand | ||
liquidatingCollateralValueLast | ||
liquidatingDebtValueLast | ||
lockedQuoteDenominatorLast | ||
lockedQuoteNumeratorLast | ||
numActiveVaultsLast | ||
numLiquidatingVaultsLast | ||
numLiquidationsAbortedLast | ||
numLiquidationsCompletedLast | ||
retainedCollateralLast | ||
totalCollateralLast | ||
totalCollateralSoldLast | ||
totalDebtLast | ||
totalOverageReceivedLast | ||
totalProceedsReceivedLast | ||
totalShortfallReceivedLast | ||
metricsCount | ||
} | ||
} | ||
}`, | ||
reserveMetrics: `query { | ||
reserveMetrics ${filterString} { | ||
nodes { | ||
id | ||
shortfallBalance | ||
totalFeeBurned | ||
totalFeeMinted | ||
} | ||
} | ||
}`, | ||
reserveAllocationMetrics: `query { | ||
reserveAllocationMetrics ${filterString} { | ||
nodes { | ||
id | ||
denom | ||
key | ||
value | ||
} | ||
} | ||
}`, | ||
reserveAllocationMetricsDailies: `query { | ||
reserveAllocationMetricsDailies ${filterString} { | ||
nodes { | ||
denom | ||
key | ||
valueLast | ||
metricsCount | ||
} | ||
} | ||
}`, | ||
}; | ||
|
||
return queries[entity]; | ||
}; | ||
|
||
export const expectations = { | ||
vaultManagerGovernances: { | ||
id: 'published.vaultFactory.managers.manager1.governance', | ||
debtLimit: '1000000000', | ||
interestRateDenominator: '100', | ||
interestRateNumerator: '1', | ||
liquidationMarginDenominator: '100', | ||
liquidationMarginNumerator: '150', | ||
liquidationPaddingDenominator: '100', | ||
liquidationPaddingNumerator: '25', | ||
liquidationPenaltyDenominator: '100', | ||
liquidationPenaltyNumerator: '1', | ||
mintFeeDenominator: '10000', | ||
mintFeeNumerator: '50', | ||
}, | ||
vaultManagerMetrics: { | ||
liquidatingCollateralBrand: 'stATOM', | ||
liquidatingCollateralValue: '0', | ||
liquidatingDebtBrand: 'IST', | ||
liquidatingDebtValue: '0', | ||
lockedQuoteDenominator: '0', | ||
lockedQuoteNumerator: '0', | ||
numActiveVaults: '0', | ||
numLiquidatingVaults: '0', | ||
numLiquidationsAborted: '0', | ||
numLiquidationsCompleted: '0', | ||
retainedCollateral: '0', | ||
totalCollateral: '0', | ||
totalCollateralSold: '0', | ||
totalDebt: '0', | ||
totalOverageReceived: '0', | ||
totalProceedsReceived: '0', | ||
totalShortfallReceived: '0', | ||
}, | ||
vaultManagerMetricsDailies: { | ||
path: 'published.vaultFactory.managers.manager1.metrics', | ||
liquidatingCollateralBrand: 'stATOM', | ||
liquidatingDebtBrand: 'IST', | ||
liquidatingCollateralValueLast: '0', | ||
liquidatingDebtValueLast: '0', | ||
lockedQuoteDenominatorLast: '0', | ||
lockedQuoteNumeratorLast: '0', | ||
numActiveVaultsLast: '0', | ||
numLiquidatingVaultsLast: '0', | ||
numLiquidationsAbortedLast: '0', | ||
numLiquidationsCompletedLast: '0', | ||
retainedCollateralLast: '0', | ||
totalCollateralLast: '0', | ||
totalCollateralSoldLast: '0', | ||
totalDebtLast: '0', | ||
totalOverageReceivedLast: '0', | ||
totalProceedsReceivedLast: '0', | ||
totalShortfallReceivedLast: '0', | ||
metricsCount: '1', | ||
}, | ||
reserveMetrics: { | ||
id: 'published.reserve.metrics', | ||
shortfallBalance: '0', | ||
totalFeeBurned: '0', | ||
totalFeeMinted: '0', | ||
}, | ||
reserveAllocationMetrics: { | ||
id: 'IST', | ||
denom: 'IST', | ||
key: 'Fee', | ||
value: '192790171', | ||
}, | ||
reserveAllocationMetricsDailies: { | ||
denom: 'IST', | ||
key: 'Fee', | ||
valueLast: '192790171', | ||
metricsCount: '1', | ||
}, | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,42 @@ | ||
#! /usr/bin/env node | ||
/* eslint-env node */ | ||
import './lockdown.mjs'; | ||
import { equal } from 'node:assert/strict'; | ||
import { getQuery, expectations } from './queries.mjs'; | ||
import { assertAllDefined } from '@agoric/internal'; | ||
|
||
const apiUrl = 'http://localhost:3000/'; | ||
console.log(`API URL set to: ${apiUrl}`); | ||
|
||
const { entity, blockHeight } = process.env; | ||
console.log(`Entity: ${entity}, Block Height: ${blockHeight}`); | ||
|
||
assertAllDefined({ entity, blockHeight }); | ||
|
||
const dailyEntities = ['vaultManagerMetricsDailies', 'reserveAllocationMetricsDailies', 'vaultStatesDailies']; | ||
const filter = dailyEntities.includes(entity) ? { blockHeightLast: blockHeight } : { blockHeight }; | ||
|
||
try { | ||
const graphqlQuery = { query: getQuery(entity, filter) }; | ||
|
||
const response = await fetch(apiUrl, { | ||
method: 'POST', | ||
headers: { | ||
'Content-Type': 'application/json', | ||
Accept: 'application/json', | ||
}, | ||
body: JSON.stringify(graphqlQuery), | ||
}); | ||
|
||
const jsonResponse = await response.json(); | ||
console.log('Response:', JSON.stringify(jsonResponse)); | ||
const nodes = jsonResponse?.data[entity]?.nodes; | ||
console.log('Node:', nodes); | ||
|
||
for (const key of Object.keys(expectations[entity])) { | ||
equal(nodes[0]?.[key], expectations[entity][key]); | ||
} | ||
} catch (error) { | ||
console.error('Error:', error); | ||
process.exit(1); | ||
} |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For a lesser waiting period it tends to fail:
At 60 seconds wait,
http://localhost:3000
consistently works and test pass.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Helpful to include a comment with what value you've found to be too small
Alternately,
scripts/validateData.mjs
could have a "wait and retry" but this is fineThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rabi-siddique I agree with Turadg's wait and retry suggestion. Such hardcoded sleep times cause flakiness in future. Something like following can be done (as a follow-up)