Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding new funding orgs #21

Merged
merged 3 commits into from
Jun 5, 2024
Merged

adding new funding orgs #21

merged 3 commits into from
Jun 5, 2024

Conversation

Sun-flow
Copy link
Contributor

@Sun-flow Sun-flow commented Jun 3, 2024

closes #18

Adds 5 funders:
Chan Zuckerberg Initiative (CZI). ror = 02qenvm24
National Center for Complementary & Integrative Health (NCCIH). ror = 00190t495
Michael J. Fox Foundation for Parkinson's Research (MJFF). ror = 03arq3225
Templeton World Charity Foundation (TWCF). ror = 00x0z1472
MBF Bioscience. Ror=02zynam48

@Sun-flow Sun-flow requested a review from saskiad June 3, 2024 23:06
@Sun-flow Sun-flow self-assigned this Jun 3, 2024
@Sun-flow
Copy link
Contributor Author

Sun-flow commented Jun 3, 2024

MBF Bioscience might need a different title or abbreviation, let me know

@@ -258,6 +267,15 @@ class TeledyneFLIR(_Organization):
registry_identifier: Literal["01j1gwp17"] = "01j1gwp17"


class TempletonWorldCharityFoundation(_Organization):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be alphabetized properly. I'm not sure why Teledyne FLIR is where it is - I thought we had an issue or a discussion open about this. Regardless, Templeton needs to be in the Ts

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I just put Templeton there because of Teledyne. I think FLIR was there because it used to be FLIR, or something of that sort. I will move both.

Copy link
Collaborator

@saskiad saskiad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check the alphabetizing
Also need to add all of these funders to the Organizations class and to the FUNDERS list

@Sun-flow Sun-flow requested a review from saskiad June 4, 2024 18:25
@saskiad saskiad merged commit 14604bb into main Jun 5, 2024
4 checks passed
@saskiad saskiad deleted the feat-18-add-funding-orgs branch June 5, 2024 04:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add funding organizations
2 participants