Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes empty parameters for amba service hook and email contact #1818

Merged
merged 2 commits into from
Nov 5, 2024
Merged

Fixes empty parameters for amba service hook and email contact #1818

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
03d9af0
Update eslzArm.json to handle empty parameters for service hook and e…
arjenhuitema Oct 30, 2024
c9eec9d
Fix Portal Accelerator issue with Azure Monitor Baseline Alerts notif…
arjenhuitema Oct 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions docs/wiki/Whats-new.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,7 @@ Here's what's changed in Enterprise Scale/Azure Landing Zones:

- Resolved a bug in the Portal Accelerator related to deploying the single platform subscription setup. Incorrect parameter settings led to the failure of AMBA, as it erroneously attempted to deploy to a standard management group structure instead of a single platform management group as needed.
- Increasing Policy assignment delay by a couple of minutes to help reduce assignment errors using the portal accelerator experience (the infamous "please wait 30 minutes and try again" error).
- An issue with the Portal Accelerator regarding the Azure Monitor Baseline Alerts notifications settings was resolved. The problem occurred when no Email Address or Service Hook was specified on the Baseline alerts and monitoring tab. In this scenario, an empty string was converted to an array, resulting in the format `[""]` instead of `[]`. This caused errors during the remediation of the Notification Assets initiative.

### September 2024

Expand Down
4 changes: 2 additions & 2 deletions eslzArm/eslzArm.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2268,7 +2268,7 @@
"value": "[parameters('userAssignedManagedIdentityName')]"
},
"ALZWebhookServiceUri": {
"value": "[array(parameters('ambaAgServiceHook'))]"
"value": "[if(empty(parameters('ambaAgServiceHook')), null(), array(parameters('ambaAgServiceHook')))]"
},
"ALZArmRoleId": {
"value": "[array(parameters('ambaAgArmRole'))]"
Expand All @@ -2283,7 +2283,7 @@
"value": "[deployment().location]"
},
"ALZMonitorActionGroupEmail": {
"value": "[array(parameters('ambaAgEmailContact'))]"
"value": "[if(empty(parameters('ambaAgEmailContact')), null(), array(parameters('ambaAgEmailContact')))]"
},
"managementSubscriptionId": {
"value": "[parameters('managementSubscriptionId')]"
Expand Down
Loading