Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes empty parameters for amba service hook and email contact #1818

Merged
merged 2 commits into from
Nov 5, 2024

Conversation

arjenhuitema
Copy link
Contributor

@arjenhuitema arjenhuitema commented Oct 30, 2024

Overview/Summary

This pull request addresses an issue with the Portal Accelerator related to the Azure Monitor Baseline Alerts notification settings. The problem occurred when neither an email address nor a service hook was specified on the Baseline alerts and monitoring tab. In such cases, an empty string was being converted to an array in the format [""] rather than []. This led to errors during the remediation of the Notification Assets initiative.

This PR fixes/adds/changes/removes

  1. Sets ALZWebhookServiceUri to null if ambaAgServiceHook is empty; otherwise, it uses the value of ambaAgServiceHook.
  2. Sets ALZMonitorActionGroupEmail to null if ambaAgEmailContact is empty; otherwise, it uses the value of ambaAgEmailContact.

Breaking Changes

None

Testing Evidence

An empty string is now properly converted to an empty array during deployment.
image

Remediation:

image

When a value is defined.
image

Testing URLs

The below URLs can be updated where the placeholders are, look for {YOUR GITHUB BRANCH NAME HERE - Remove Curly Brackets Also} & {YOUR GITHUB BRANCH NAME HERE - Remove Curly Brackets Also}, to allow you to test your portal deployment experience.

Please also replace the curly brackets on the placeholders {}

Azure Public

Deploy To Azure

As part of this Pull Request I have

  • Checked for duplicate Pull Requests
  • Associated it with relevant issues, for tracking and closure.
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Performed testing and provided evidence.
  • Ensured contribution guidance is followed.
  • Updated relevant and associated documentation.
  • Updated the "What's New?" wiki page (located: /docs/wiki/whats-new.md)

Copy link
Member

@Springstone Springstone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jtracey93 jtracey93 merged commit 7749691 into main Nov 5, 2024
3 of 4 checks passed
@jtracey93 jtracey93 deleted the 1792-amba-array-parameters branch November 5, 2024 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug Report: Incorrect parameter type and default value for ambaAgServiceHook
3 participants