Fixes empty parameters for amba service hook and email contact #1818
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview/Summary
This pull request addresses an issue with the Portal Accelerator related to the Azure Monitor Baseline Alerts notification settings. The problem occurred when neither an email address nor a service hook was specified on the Baseline alerts and monitoring tab. In such cases, an empty string was being converted to an array in the format
[""]
rather than[]
. This led to errors during the remediation of the Notification Assets initiative.This PR fixes/adds/changes/removes
ALZWebhookServiceUri
to null ifambaAgServiceHook
is empty; otherwise, it uses the value ofambaAgServiceHook
.ALZMonitorActionGroupEmail
to null ifambaAgEmailContact
is empty; otherwise, it uses the value ofambaAgEmailContact
.Breaking Changes
None
Testing Evidence
An empty string is now properly converted to an empty array during deployment.
Remediation:
When a value is defined.
Testing URLs
The below URLs can be updated where the placeholders are, look for
{YOUR GITHUB BRANCH NAME HERE - Remove Curly Brackets Also}
&{YOUR GITHUB BRANCH NAME HERE - Remove Curly Brackets Also}
, to allow you to test your portal deployment experience.Azure Public
As part of this Pull Request I have
main
branch/docs/wiki/whats-new.md
)