[AppService] az webapp list-runtimes: Remove the JBoss '_byol' entries from the output for webapps with Linux OS
#30673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dfuenzalida
requested review from
jsntcy,
zhoxing-ms and
yanzhudd
as code owners
️✔️AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
microsoft-github-policy-service
bot
requested review from
yonzhan and
wangzelin007
|
Pinging @jvano for review |
microsoft-github-policy-service
bot
added
customer-reported
dfuenzalida
changed the title
az webapp list-runtimes --os linuxaz webapp list-runtimes --os linux
dfuenzalida
changed the title
az webapp list-runtimes --os linuxaz webapp list-runtimes --os linux
dfuenzalida
changed the title
az webapp list-runtimes --os linuxaz webapp list-runtimes --os linux
dfuenzalida
changed the title
az webapp list-runtimes --os linuxaz webapp list-runtimes --os linux
zhoxing-ms
changed the title
az webapp list-runtimes --os linuxaz webapp list-runtimes: Remove the JBoss '_byol' entries from the output of az webapp list-runtimes --os linux
zhoxing-ms
previously approved these changes
Jan 20, 2025
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
dfuenzalida
changed the title
az webapp list-runtimes: Remove the JBoss '_byol' entries from the output of az webapp list-runtimes --os linuxaz webapp list-runtimes: Remove the JBoss '_byol' entries from the output of 'az webapp list-runtimes --os linux'
|
/azp run |
|
Commenter does not have sufficient privileges for PR 30673 in repo Azure/azure-cli |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
@yonzhan all checks passed except the check for Pull Request Title and Content. The error reads: I'm not sure what's the issue since I've tried variants in between quotes and between backquotes and seemed to have the same issue. Feel free to edit the PR's title. Thanks! |
zhoxing-ms
reviewed
Jan 23, 2025
Comment on lines
+4136
to
+4137
| # Remove the JBoss'_byol' entries from the output | ||
| runtimes = [(r, v, au) for (r, v, au) in runtimes if r is not None and not r.endswith("_byol")] # pylint: disable=line-too-long |
There was a problem hiding this comment.
May I ask if removing JBoss '_byol' entries will cause a breaking change for the customer?
There was a problem hiding this comment.
Not a breaking change, because the feature they belong to is not live yet and these entries should not be visible to users.
zhoxing-ms
changed the title
az webapp list-runtimes: Remove the JBoss '_byol' entries from the output of 'az webapp list-runtimes --os linux'az webapp list-runtimes: Remove the JBoss '_byol' entries from the output for webapp with Linux OS
zhoxing-ms
changed the title
az webapp list-runtimes: Remove the JBoss '_byol' entries from the output for webapp with Linux OSaz webapp list-runtimes: Remove the JBoss '_byol' entries from the output for webapps with Linux OS
zhoxing-ms
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
az webapp list-runtimesDescription
App Service Linux uses internal variants of the JBoss EAP runtimes with a
_byolsuffix in their name and those should be removed from the output to avoid confusion.Testing Guide
Running
az webapp list-runtimes --os linuxshould not contain any entries which had_byolin their runtime name.Before:
After:
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.