Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AppService] az webapp list-runtimes: Remove the JBoss '_byol' entries from the output for webapps with Linux OS #30673

Merged
merged 2 commits into from
Jan 24, 2025
Merged

[AppService] az webapp list-runtimes: Remove the JBoss '_byol' entries from the output for webapps with Linux OS #30673

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4d91f53
Remove the JBoss'_byol' entries from the output
dfuenzalida Jan 18, 2025
a9ff6dd
Remove extra parens
dfuenzalida Jan 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/azure-cli/azure/cli/command_modules/appservice/custom.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4133,6 +4133,8 @@ def _parse_major_version_linux(self, major_version, parsed_results):
(linux_container_settings.additional_properties.get("java17Runtime"), "17", linux_container_settings.is_auto_update), # pylint: disable=line-too-long
(linux_container_settings.java11_runtime, "11", linux_container_settings.is_auto_update),
(linux_container_settings.java8_runtime, "8", linux_container_settings.is_auto_update)]
# Remove the JBoss'_byol' entries from the output
runtimes = [(r, v, au) for (r, v, au) in runtimes if r is not None and not r.endswith("_byol")] # pylint: disable=line-too-long
Comment on lines +4136 to +4137
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May I ask if removing JBoss '_byol' entries will cause a breaking change for the customer?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a breaking change, because the feature they belong to is not live yet and these entries should not be visible to users.

for runtime_name, version, auto_update in [(r, v, au) for (r, v, au) in runtimes if r is not None]:
runtime = self.Runtime(display_name=runtime_name,
configs={"linux_fx_version": runtime_name},
Expand Down
Loading