-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refac: made some attributes of VAEAlgorithmConfig
optional
#261
refac: made some attributes of VAEAlgorithmConfig
optional
#261
Conversation
… strictly necessary at inference time
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That means that we would need to check whether they have been assigned for training.
Would it make sense to simply give them a default value?
I think I got your point, but let me be sure. The problem you are pointing out is that in this way we could instantiate an Algorithm config that will raise a RuntimrError during training since some attributes are not defined, right? If this is the case, yeah good point. I guess a solution is to change the default values of the pydantic configs, e.g.,
What do you think? |
Or we could also skip this PR. However, it is really ugly to load a loss config or an optimizer config which are just useless at inference time... |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #261 +/- ##
=======================================
Coverage 87.80% 87.80%
=======================================
Files 137 137
Lines 4971 4971
=======================================
Hits 4365 4365
Misses 606 606 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
Sorry I lost track of this. I do prefer having an unused parameter class than guarding against it being |
I completely see your point. Let's skip this PR then, not important at all! |
Description
model
,Optional
inVAEAlgortihmConfig
.model
attribute is needed. This allows to simplify model initialization for evaluation.Optional
, addedNone
default if needed.Please ensure your PR meets the following requirements: