Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refac: made some attributes of VAEAlgorithmConfig optional #261

Closed
wants to merge 4 commits into from
Closed

refac: made some attributes of VAEAlgorithmConfig optional #261

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
fe31e22
refac: made some fields in `VAEAlgorithmConfig` as optional since not…
federico-carrara Oct 31, 2024
822d039
refac: loss default is now `None`
federico-carrara Nov 4, 2024
4f9e5bd
Merge branch 'main' into fc/refac/optionalize
jdeschamps Nov 18, 2024
654dd1b
Merge branch 'main' into fc/refac/optionalize
jdeschamps Nov 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/careamics/config/vae_algorithm_model.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,17 +41,17 @@ class VAEAlgorithmConfig(BaseModel):
algorithm: Literal["musplit", "denoisplit"]

# NOTE: these are all configs (pydantic models)
loss: LVAELossConfig
model: Union[LVAEModel, CustomModel] = Field(discriminator="architecture")
loss: Optional[LVAELossConfig] = None
noise_model: Optional[MultiChannelNMConfig] = None
noise_model_likelihood: Optional[NMLikelihoodConfig] = None
gaussian_likelihood: Optional[GaussianLikelihoodConfig] = None

# Optional fields
optimizer: OptimizerModel = OptimizerModel()
optimizer: Optional[OptimizerModel] = OptimizerModel()
"""Optimizer to use, defined in SupportedOptimizer."""

lr_scheduler: LrSchedulerModel = LrSchedulerModel()
lr_scheduler: Optional[LrSchedulerModel] = LrSchedulerModel()

@model_validator(mode="after")
def algorithm_cross_validation(self: Self) -> Self:
Expand Down
Loading