-
Notifications
You must be signed in to change notification settings - Fork 710
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consistently use uid_t/gid_t for credentials #561
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please rebase
1a64f38
to
40f2c8f
Compare
Rebased to 3.4.10 and forced pushed a tweak to |
It looks like I hit the Windows build error:
I'll take a look at this and push a fix. |
Hi @goncaloalmeida, PR is rebased, and all the tests pass. |
Tweaked the uid/gid deserialization. |
ecd2ee4
to
1e162f8
Compare
Applied similar changes to Android's internal_android.hpp
#endif | ||
|
||
inline constexpr uid_t ANY_UID = (std::numeric_limits<uid_t>::max)(); | ||
inline constexpr gid_t ANY_GID = (std::numeric_limits<uid_t>::max)(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
inline constexpr gid_t ANY_GID = (std::numeric_limits<uid_t>::max)(); | |
inline constexpr gid_t ANY_GID = (std::numeric_limits<gid_t>::max)(); |
Consistent use
uid_t
/gid_t
types for user/group IDs rather than sometimes usingstd::uint32_t
.We found this important in 3.1.20 and 3.3.8 on QNX, but also using these types should make vsomeip more platform independent.