fix: raise errors when metadata discovery is not allowed #1534
+232
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code Coverage (Ubuntu)Diff against developResults for commit: 774a65b Minimum allowed coverage is ♻️ This comment has been updated with latest results |
|
Code Coverage (Windows)Diff against developResults for commit: 774a65b Minimum allowed coverage is ♻️ This comment has been updated with latest results |
jlahovnik
requested changes
Feb 20, 2025
| ) | ||
| else False | ||
| ) | ||
| raise_mtd_discovery_error = ( |
There was a problem hiding this comment.
Logic is not correct when raise_mtd_discovery_error is is True for provider and False for product type.
| @@ -1283,11 +1284,39 @@ def format_query_params( | |||
| config.metadata_mapping, | |||
| **config.products.get(product_type, {}).get("metadata_mapping", {}), | |||
| ) | |||
| raise_mtd_discovery_error = ( | |||
There was a problem hiding this comment.
Please add some comments for this part of the code!
it indicates whether metadata discovery may fail the search request or not
the case where raise_mtd_discovery_error was True at provider level and False at product type level was not handled
anesson-cs
force-pushed
the
wide-range-with-no-data
branch
2 times, most recently
from
d894bc8 to
6ed5e38
Compare
anesson-cs
force-pushed
the
wide-range-with-no-data
branch
from
6ed5e38 to
774a65b
Compare
jlahovnik
approved these changes
Feb 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1531
For
MO_OCEANCOLOUR_GLO_BGC_L3_NRT_009_101andMO_OCEANCOLOUR_GLO_BGC_L4_NRT_009_102product types, the range was not wide enought and only very recent products are available.For
CLMS_CORINE,wekeodoes not accept date parameters but does not raise an error. Then, it has been handled in two steps:startTimeFromAscendingNodeandcompletionTimeFromAscendingNodeare only mapped for this product type with this providerraise_mtd_discovery_errorhas been set up indiscover_metadata.search_paramconfiguration. It is a boolean parameter, and if it is instantiated toTrueand the user searches a product type with a parameter not among the queryables of this product type, an error is raised before the search request. It would make sure that the user knows his request is wrong instead of wondering the reason why he does have any result. The value by default ofraise_mtd_discovery_errorisFalse. This keyword can be used at provider search plugin or at product type configuration level, the last one having the priority over the first one.Note: I chose to put
raise_mtd_discovery_erroratdiscover_metadata.search_paramlevel, but afterwards I am wondering if it should be better to put it atdiscover_metadatalevel directly, likeauto_discoveryparameter.