Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3 karlov manor cards #4583

Closed
wants to merge 6 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions forge-gui/res/cardsfolder/upcoming/krenkos_buzzcrusher.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
Name:Krenko's Buzzcrusher
ManaCost:2 R R
Types:Artifact Creature Insect Thopter
PT:4/4
K:Flying
K:Trample
T: Mode$ ChangesZone | Origin$ Any | Destination$ Battlefield | ValidCard$ Card.Self | Execute$ DBDestroy | TriggerDescription$ When CARDNAME enters the battlefield, for each player, destroy up to one nonbasic land that player controls. For each land destroyed this way, its controller may search their library for a basic land card, put it onto the battlefield tapped, then shuffle.
SVar:DBDestroy:DB$ Destroy | ValidTgts$ Land.nonBasic | TgtPrompt$ Select up to one nonbasic land each player controls | TargetMin$ 0 | TargetMax$ OneEach | TargetsWithDifferentControllers$ True | RememberLKI$ True | SubAbility$ DBSearch
Copy link
Contributor Author

@Glorax Glorax Jan 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How do I make it not target? Would it require radical modifications (like a Repeat combined with a ChooseCard) or is it very simple?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yea, pretty much like you described, no faster way

SVar:DBSearch:DB$ ChangeZone | Origin$ Library | Destination$ Battlefield | ChangeType$ Land.Basic | ChangeNum$ 1 | DefinedPlayer$ TargetedController
SVar:OneEach:PlayerCountPlayers$Amount
Oracle:Flying, trample\nWhen Krenko's Buzzcrusher enters the battlefield, for each player, destroy up to one nonbasic land that player controls. For each land destroyed this way, its controller may search their library for a basic land card, put it onto the battlefield tapped, then shuffle.
8 changes: 8 additions & 0 deletions forge-gui/res/cardsfolder/upcoming/red_herring.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
Name:Red Herring
ManaCost:1 R
Types:Artifact Creature Clue Fish
PT:2/2
K:Haste
S:Mode$ MustAttack | ValidCreature$ Card.Self | Description$ CARDNAME attacks each combat if able.
A:AB$ Draw | Cost$ 2 Sac<1/CARDNAME> | SpellDescription$ Draw a card.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DeckHas:Ability$Sacrifice

Oracle:Haste\nRed Herring attacks each combat if able.\n{2}, Sacrifice Red Herring: Draw a card.
13 changes: 13 additions & 0 deletions forge-gui/res/cardsfolder/upcoming/sharp_eyed_rookie.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
Name:Sharp-Eyed Rookie
ManaCost:1 G
Types:Creature Human Detective
PT:2/2
K:Vigilance
T:Mode$ ChangesZone | Origin$ Any | Destination$ Battlefield | ValidCard$ Creature.YouCtrl+powerGTX,Creature.YouCtrl+powerGTY | TriggerZones$ Battlefield | Execute$ TrigPutCounter | TriggerDescription$ Whenever a creature enters the battlefield under your control, if its power is greater than CARDNAME's power or its toughness, put a +1/+1 counter on CARDNAME and investigate. (Create a Clue token. It's an artifact with "{2}, Sacrifice this artifact: Draw a card.")
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to need more detail on what's wrong with the Valid. (Important note: Sharp-Eyed Rookie only cares about the power of the creature entering, which is a major thing separating it from Evolve.)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmn right, I misread it to compare both toughness together too

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually it turns out your Oracle is incomplete

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tool4ever What a careless mistake! I must have somehow glanced over a whole line of text.

SVar:TrigPutCounter:DB$ PutCounter | ConditionDefined$ TriggeredCard | ConditionPresent$ Creature.powerGTX,Creature.powerGTY | CounterType$ P1P1 | SubAbility$ TrigInvestigate
SVar:TrigInvestigate:DB$ Investigate
SVar:X:Count$CardPower
SVar:Y:Count$CardToughness
DeckHints:Ability$Investigate
DeckHas:Ability$Investigate|Token|Counters
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add Sacrifice

Oracle:Vigilance\nWhenever a creature enters the battlefield under your control, if its power is greater than Sharp-Eyed Rookie's power or its toughness, put a +1/+1 counter on Sharp-Eyed Rookie and investigate. (Create a Clue token. It's an artifact with "{2}, Sacrifice this artifact: Draw a card.")
1 change: 1 addition & 0 deletions forge-gui/res/editions/Murders at Karlov Manor.txt
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,7 @@ ScryfallCode=MKM
133 C Innocent Bystander @Warren Mahy
134 U Knife @Tony Foti
135 R Krenko, Baron of Tin Street @Brian Valeza
136 R Krenko's Buzzcrusher @Joshua Raphael
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd say normally, don't worry about adding to the editions when scripting a card because it will be automatically added to the latest set if it's not in the edition and they get updated daily anyway, but may as well leave this in

137 R Lamplight Phoenix @Ryan Pancoast
138 C Offender at Large @Mike Bierek
140 R Pyrotechnic Performer @Peter Polach
Expand Down
2 changes: 1 addition & 1 deletion forge-gui/res/editions/Mystery Booster Playtest Cards.txt
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ ScryfallCode=CMB1
59 R Planequake @Chris Kiritz
60 R Problematic Volcano @Gavin Verhey
61 R Queue of Beetles @Brendan Sell
62 R Red Herring @Chris Mooney
62 R Red Herring (Playtest) @Chris Mooney
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@paulsnoops is this right?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, (Playtest) shouldn't be there as it's not actually part of the name. Although I see why you've added it as there are now two different cards with this name, gg Wizards. Maybe we just comment it out for now as this card isn't in Forge at the moment.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tehdiplomat had a good suggestion that this card should be listed instead as P-Red Herring

63 R Seasoned Weaponsmith @Mark L. Gottlieb
64 R Siege Elemental @Levi Parker
65 R Throat Wolf @Sam Stoddard
Expand Down