-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrite folder module and migrate to new collection API. #536
Conversation
First of all, the restructured module looks great. As for #533, I would say that it is more of a feature request. |
@msekania I think it makes sense for you to open your PR based on this branch. That way, we can either merge your changes into this branch, or we merge this PR, which will make your PR automatically move to the |
I made a PR, see #539 , but there are some merge issues. |
@robin-checkmk, yes, let's wait for @lgetwan. I sync and pulled this branch before branching out to mine. |
Thanks for creating this pull request, @msekania! |
…etwork scan data if it exists.
I will close this PR, as its complete contents were already merged into #539, where they have been improved further. |
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
The folder module was still a bit oldschool spaghetti code.
What is the new behavior?
The folder module now uses the new API