feat: merkle damgard and poseidon2 #1407
Open
+391
−198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivokub
requested changes
Feb 13, 2025
| if err != nil { | ||
| return nil, fmt.Errorf("could not create poseidon2 hasher: %w", err) | ||
| } | ||
| return hash.NewMerkleDamgardHasher(api, f, 0), nil |
There was a problem hiding this comment.
Is IV=0 temporary or it indeed doesn't have preimage?
| } | ||
|
|
||
| // SingleFunction returns a test function that can run a simple circuit consisting of function f, and match its output with outs | ||
| func SingleFunction(curve ecc.ID, f func(frontend.API) []frontend.Variable, outs ...frontend.Variable) func(*testing.T) { |
There was a problem hiding this comment.
I think it is a cool idea, but currently imo it is still not ready. I have several issues with the implementation currently:
- you already have TODO that the registry is not thread safe. If adding a new feature then I would avoid adding implementation debt.
- this utility function prevents self-documenting tests. I'm referring (myself and also if anyone asks in dicusssions or through communication) quite a lot to test circuits to see how to implement. But this abstraction makes the tests a bit more confusing as would have to refer to the
snarkFunctionTestCircuitdefinition and the provided function. - it only uses
IsSolved, but this tests only against test engine. It is good, but still not perfect and there have been cases where the actual solver/prover etc. differs from the test engine. And it also prevents running Solidity tests easily etc.
I would remove it and define the circuit directly in the std/hash/poseidon2/poseidon2_test.go file, it is only a few lines of code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Companion to Consensys/gnark-crypto#623
This PR introduces a generic Merkle Damgard construction and uses it to instantiate Poseidon2 as a full hash function.
(Parameters only for BLS12-377)