-
Notifications
You must be signed in to change notification settings - Fork 414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: merkle damgard and poseidon2 #1407
Open
Tabaie
wants to merge
13
commits into
master
Choose a base branch
from
feat/poseidon2-hash
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+391
−198
Open
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
5e00636
feat: merkle damgard and poseidon2
Tabaie 63038e6
fix bad use of h.Permutation, and test
Tabaie a8e353f
docs: remove incomplete comment
Tabaie 1b57817
test: against gnark-crypto
Tabaie 37a79fa
chore: integrate gnark-crypto refactors
Tabaie 2473dea
refactor: rename NewHash to NewPermutation
Tabaie 5032ce6
Merge branch 'master' into feat/poseidon2-hash
Tabaie 254dd75
refactor: align implementation with gnark-crypto
ivokub cc342a0
refactor: align naming with gnark-crypto
ivokub 4b9aaf2
feat: take default parameters from gnark-crypto
ivokub ffdba7f
chore: rename file
ivokub d6fcd5d
refactor: rename constructor to align with gnark-crypto
ivokub 5c46d09
fix: add danger when calling permute for t=2,3 for now
ivokub File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
package poseidon2 | ||
|
||
import ( | ||
"fmt" | ||
|
||
"github.com/consensys/gnark/frontend" | ||
"github.com/consensys/gnark/std/hash" | ||
poseidon2 "github.com/consensys/gnark/std/permutation/poseidon2" | ||
) | ||
|
||
// NewMerkleDamgardHasher returns a Poseidon2 hasher using the Merkle-Damgard | ||
// construction with the default parameters. | ||
func NewMerkleDamgardHasher(api frontend.API) (hash.FieldHasher, error) { | ||
f, err := poseidon2.NewPoseidon2(api) | ||
if err != nil { | ||
return nil, fmt.Errorf("could not create poseidon2 hasher: %w", err) | ||
} | ||
return hash.NewMerkleDamgardHasher(api, f, 0), nil | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,28 @@ | ||
package poseidon2 | ||
|
||
import ( | ||
"testing" | ||
|
||
"github.com/consensys/gnark-crypto/ecc" | ||
"github.com/consensys/gnark-crypto/ecc/bls12-377/fr/poseidon2" | ||
"github.com/consensys/gnark/frontend" | ||
"github.com/consensys/gnark/test" | ||
"github.com/stretchr/testify/require" | ||
) | ||
|
||
func TestPoseidon2Hash(t *testing.T) { | ||
// prepare expected output | ||
h := poseidon2.NewMerkleDamgardHasher() | ||
for i := range 5 { | ||
_, err := h.Write([]byte{byte(i)}) | ||
require.NoError(t, err) | ||
} | ||
res := h.Sum(nil) | ||
|
||
test.SingleFunction(ecc.BLS12_377, func(api frontend.API) []frontend.Variable { | ||
hsh, err := NewMerkleDamgardHasher(api) | ||
require.NoError(t, err) | ||
hsh.Write(0, 1, 2, 3, 4) | ||
return []frontend.Variable{hsh.Sum()} | ||
}, res)(t) | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is IV=0 temporary or it indeed doesn't have preimage?