Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(propagation): remove b3 single header #12167

Merged
merged 8 commits into from
Feb 3, 2025

Conversation

mabdinur
Copy link
Contributor

@mabdinur mabdinur commented Jan 30, 2025

Blocked by: DataDog/system-tests#3943

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@mabdinur mabdinur requested review from a team as code owners January 30, 2025 15:32
Copy link
Contributor

github-actions bot commented Jan 30, 2025

CODEOWNERS have been resolved as:

releasenotes/notes/remove-b3-single--4c16c32466c69709.yaml              @DataDog/apm-python
ddtrace/propagation/http.py                                             @DataDog/apm-sdk-api-python
ddtrace/settings/_config.py                                             @DataDog/apm-core-python
docs/configuration.rst                                                  @DataDog/python-guild
tests/tracer/test_global_config.py                                      @DataDog/apm-sdk-api-python
tests/tracer/test_propagation.py                                        @DataDog/apm-sdk-api-python

@pr-commenter
Copy link

pr-commenter bot commented Jan 30, 2025

Benchmarks

Benchmark execution time: 2025-02-03 15:55:43

Comparing candidate commit 5fbd839 in PR branch munir/remove-b3-single-headers with baseline commit a22143d in branch 3.x-staging.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 394 metrics, 2 unstable metrics.

@mabdinur mabdinur enabled auto-merge (squash) January 31, 2025 15:23
@ZStriker19
Copy link
Contributor

Shouldn’t we remove it from http.py and also tests/tracer/test_propagation.py?

@datadog-dd-trace-py-rkomorn
Copy link

datadog-dd-trace-py-rkomorn bot commented Jan 31, 2025

Datadog Report

Branch report: munir/remove-b3-single-headers
Commit report: 5fbd839
Test service: dd-trace-py

✅ 0 Failed, 130 Passed, 1378 Skipped, 4m 18.74s Total duration (35m 11.91s time saved)

docs/configuration.rst Outdated Show resolved Hide resolved
docs/configuration.rst Outdated Show resolved Hide resolved
@mabdinur mabdinur merged commit 1419b2f into 3.x-staging Feb 3, 2025
635 checks passed
@mabdinur mabdinur deleted the munir/remove-b3-single-headers branch February 3, 2025 16:22
mabdinur added a commit that referenced this pull request Feb 3, 2025
Blocked by: DataDog/system-tests#3943

## Checklist
- [ ] PR author has checked that all the criteria below are met
- The PR description includes an overview of the change
- The PR description articulates the motivation for the change
- The change includes tests OR the PR description describes a testing
strategy
- The PR description notes risks associated with the change, if any
- Newly-added code is easy to change
- The change follows the [library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
- The change includes or references documentation updates if necessary
- Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))

## Reviewer Checklist
- [ ] Reviewer has checked that all the criteria below are met 
- Title is accurate
- All changes are related to the pull request's stated goal
- Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes
- Testing strategy adequately addresses listed risks
- Newly-added code is easy to change
- Release note makes sense to a user of the library
- If necessary, author has acknowledged and discussed the performance
implications of this PR as reported in the benchmarks PR comment
- Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants