i#1973 musl: Don't pass SS_ONSTACK to sigaltstack in tests #7198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
POSIX.1 requires SS_ONSTACK to appear only in a stack_t retrieved from sigaltstack(), not one passed to it. musl checks the invalid flag and will bail out with EINVAL before issuing a syscall in this case. This commit sets ss_flags to zero in the test instead, on both glibc and musl this should issue a syscall and result in an EPERM failure. Issue: DynamoRIO#1973
derekbruening
approved these changes
Jan 21, 2025
ziyao233
changed the title
ziyao233
changed the title
derekbruening
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
POSIX.1 requires SS_ONSTACK to appear only in a stack_t retrieved from
sigaltstack(), not one passed to it. musl checks the invalid flag and will
bail out with EINVAL before issuing a syscall in this case, failing the test.
This commit sets ss_flags to zero instead, on both glibc and musl this
should issue a syscall, which fixes assertion failures encountered in
linux.signal*, api.static_signal and drcachesim.burst_threads on musl.
Issue: #1973