Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i#1973 musl: Don't pass SS_ONSTACK to sigaltstack in tests #7198

Merged
merged 6 commits into from
Feb 4, 2025
Merged

i#1973 musl: Don't pass SS_ONSTACK to sigaltstack in tests #7198

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
8a09259
i#1973: Fix linux.signal* tests on musl
ziyao233 Jan 18, 2025
7fa2a09
Apply fix for test drcachesim.burst_threads
ziyao233 Feb 3, 2025
261b527
Apply fix for test api.static_signal
ziyao233 Feb 3, 2025
e4248c8
Apply fix for test linux.bad-signal-stack
ziyao233 Feb 3, 2025
4a38bf5
Merge branch 'master' into musl/linux.signalNNNN
ziyao233 Feb 3, 2025
17f874f
Merge remote-tracking branch 'origin/master' into musl/linux.signalNNNN
ziyao233 Feb 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion clients/drcachesim/tests/burst_threads.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ void *
# define ALT_STACK_SIZE (SIGSTKSZ * 2)
sigstack.ss_sp = (char *)malloc(ALT_STACK_SIZE);
sigstack.ss_size = ALT_STACK_SIZE;
sigstack.ss_flags = SS_ONSTACK;
sigstack.ss_flags = 0;
int res = sigaltstack(&sigstack, NULL);
assert(res == 0);
#endif
Expand Down
2 changes: 1 addition & 1 deletion suite/tests/api/static_signal.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ thread_func(void *arg)
int rc;
sigstack.ss_sp = (char *)malloc(ALT_STACK_SIZE);
sigstack.ss_size = ALT_STACK_SIZE;
sigstack.ss_flags = SS_ONSTACK;
sigstack.ss_flags = 0;
rc = sigaltstack(&sigstack, NULL);
ASSERT_NOERR(rc);
signal_cond_var(thread_ready);
Expand Down
2 changes: 1 addition & 1 deletion suite/tests/linux/bad-signal-stack.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ main(int argc, char *argv[])
/* Make an alternate stack that's not writable. */
sigstack.ss_sp = alloc;
sigstack.ss_size = ALT_STACK_SIZE;
sigstack.ss_flags = SS_ONSTACK;
sigstack.ss_flags = 0;
rc = sigaltstack(&sigstack, NULL);
ASSERT_NOERR(rc);
protect_mem((void *)sigstack.ss_sp, ALT_STACK_SIZE, ALLOW_READ);
Expand Down
2 changes: 1 addition & 1 deletion suite/tests/linux/signal-base.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ static void
stack_t sigstack;
ziyao233 marked this conversation as resolved.
Show resolved Hide resolved
sigstack.ss_sp = siginfo; /* will fail: just need sthg */
sigstack.ss_size = ALT_STACK_SIZE;
sigstack.ss_flags = SS_ONSTACK;
sigstack.ss_flags = 0;
ziyao233 marked this conversation as resolved.
Show resolved Hide resolved
int rc = sigaltstack(&sigstack, NULL);
assert(rc == -1 && errno == EPERM);
#endif
Expand Down
Loading