Reject dynakubes that use public image and not read only oneAgents (release-1.4) #4346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
waodim
requested review from
andriisoldatenko,
gkrenn,
0sewa0,
chrismuellner,
StefanHauth and
aorcholski
and removed request for
a team
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## release-1.4 #4346 +/- ##
============================================
Coverage 64.20% 64.20%
============================================
Files 401 401
Lines 27010 27015 +5
============================================
+ Hits 17341 17346 +5
Misses 8302 8302
Partials 1367 1367
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
0sewa0
approved these changes
Jan 27, 2025
andriisoldatenko
approved these changes
Jan 28, 2025
| @@ -23,6 +23,8 @@ Use a nodeSelector to avoid this conflict. Conflicting DynaKubes: %s` | |||
|
|
|||
| errorVolumeStorageReadOnlyModeConflict = `The DynaKube specification specifies a read-only host file system while OneAgent has volume storage enabled.` | |||
|
|
|||
| errorPublicImageWithWrongConfig = `The DynaKube specification specifies a custom (and therefor probably a public) image in combination with a mode that needs write permissions for volume mounts.` | |||
There was a problem hiding this comment.
Suggested change
| errorPublicImageWithWrongConfig = `The DynaKube specification specifies a custom (and therefor probably a public) image in combination with a mode that needs write permissions for volume mounts.` | |
| errorPublicImageWithWrongConfig = `Custom OneAgent image is only supported when CSI Driver is used.` |
It would be much nicer to have a guide in the official documentation to link to explaining the feature flag, but for now I think we can boil it down to this.
StefanHauth
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ticket
Previously when a dynakube was applied that had a mode that does not use read only oneagents (so everything that is not cloudNative or hostMon with csi) and a custom image (which we interpret as public images) then the oneAgent pods would run into a CrashLoopBackOff error.
In the pods you'd find this message:
With this PR this configuration is now rejected in the first place.
How can this be tested?
Try those modes in combination with a custom image
example:
helm install dynatrace-operator -n dynatrace oci://public.ecr.aws/dynatrace/dynatrace-operator --version 1.4.0 -n dynatrace --set csidriver.enabled=false