Decode arbitrary VID payloads #1231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make tx-iterator more concise and refactor `QueryablePayload::len` to use table abstraction
- re-introduce `get_payload_range` inside `TxTable` for safe and easy access to the transaction payload in `Payload::parse_ns_payload` and `QueryablePayload::transaction`. - let `NamespaceTable::get_payload_range` conveniently return the ns_id with the range
akonring
requested review from
nomaxg,
philippecamacho,
ImJeremyHe,
sveitser and
jbearer
as code owners
ggutoski
approved these changes
Mar 18, 2024
There was a problem hiding this comment.
Great progress. I think we can merge as soon as we update to latest main.
TODO in future PRs:
- more tidying. (Definitely need to remove all the
TxTableEntryWordtype params.) - improve tests. eg.
merge arbitrary_payloadswithmalformed_payloads, build better infra.
|
Thanks for looking at this big PR. It is a joy to help getting some of the TODOs resolved in this part of the code 💯. After our discussion on testing for duplicate namespace ids, I've created an issue for this specific task here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #785