test(alert): Add token theming tests #9356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
macandcheese
commented
May 16, 2024
| ); | ||
| }); | ||
| describe.skip("queued Alerts", () => { | ||
| /* Currently we cannot programmatically simulate a queued Alert in a `themed` test */ |
There was a problem hiding this comment.
Let me know if you'd like me to remove this block instead of using .skip() @alisonailea
There was a problem hiding this comment.
I think you can achieve this by following this pattern.
WRT your original question, we can skip and create a follow-up issue to keep track of it.
There was a problem hiding this comment.
Nice, I'll update in this PR.
There was a problem hiding this comment.
Updated + merging 🎈
jcfranco
approved these changes
May 17, 2024
| ); | ||
| }); | ||
| describe.skip("queued Alerts", () => { | ||
| /* Currently we cannot programmatically simulate a queued Alert in a `themed` test */ |
There was a problem hiding this comment.
I think you can achieve this by following this pattern.
WRT your original question, we can skip and create a follow-up issue to keep track of it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #7180
Summary
Add token theming tests for Alert