Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(alert): Add token theming tests #9356

Merged
merged 5 commits into from
May 20, 2024
Merged

test(alert): Add token theming tests #9356

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
2be6609
test(alert): Add token theming tests
macandcheese May 16, 2024
fbba241
Clean up
macandcheese May 16, 2024
771a967
Merge branch 'epic/7180-component-tokens' into macandcheese/token-tes…
macandcheese May 17, 2024
a30eb1d
Clean up
macandcheese May 20, 2024
846baba
Merge branch 'epic/7180-component-tokens' into macandcheese/token-tes…
macandcheese May 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
104 changes: 103 additions & 1 deletion packages/calcite-components/src/components/alert/alert.e2e.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import { E2EElement, E2EPage, newE2EPage } from "@stencil/core/testing";
import { html } from "../../../support/formatting";
import { accessible, defaults, hidden, HYDRATED_ATTR, renders, t9n } from "../../tests/commonTests";
import { accessible, defaults, hidden, HYDRATED_ATTR, renders, t9n, themed } from "../../tests/commonTests";
import { ComponentTestTokens } from "../../tests/commonTests/themed";
import { getElementXY } from "../../tests/utils";
import { openClose } from "../../tests/commonTests";
import { CSS, DURATIONS } from "./resources";
Expand Down Expand Up @@ -43,6 +44,107 @@ describe("calcite-alert", () => {
openClose("calcite-alert");
});

describe("theme", () => {
describe("default", () => {
const tokens: ComponentTestTokens = {
"--calcite-alert-accent-color": {
shadowSelector: `.${CSS.container}`,
targetProp: "borderBlockStartColor",
},
"--calcite-alert-background-color": {
shadowSelector: `.${CSS.container}`,
targetProp: "backgroundColor",
},
"--calcite-alert-border-color": {
shadowSelector: `.${CSS.container}`,
targetProp: "borderInlineColor",
},
"--calcite-alert-corner-radius": {
shadowSelector: `.${CSS.container}`,
targetProp: "borderRadius",
},
"--calcite-alert-shadow": {
targetProp: "boxShadow",
shadowSelector: `.${CSS.container}`,
},
"--calcite-alert-icon-color": {
shadowSelector: `.${CSS.icon} >>> calcite-icon`,
targetProp: "color",
},
"--calcite-alert-close-background-color": {
shadowSelector: `.${CSS.close}`,
targetProp: "backgroundColor",
},
"--calcite-alert-close-background-color-hover": {
shadowSelector: `.${CSS.close}`,
targetProp: "backgroundColor",
state: { hover: { attribute: "class", value: CSS.close } },
},
"--calcite-alert-close-background-color-active": {
shadowSelector: `.${CSS.close}`,
targetProp: "backgroundColor",
state: { press: { attribute: "class", value: CSS.close } },
},
"--calcite-alert-close-background-color-focus": {
shadowSelector: `.${CSS.close}`,
targetProp: "backgroundColor",
state: { focus: { attribute: "class", value: CSS.close } },
},
"--calcite-alert-close-icon-color-hover": {
shadowSelector: `.${CSS.close}`,
targetProp: "color",
state: { hover: { attribute: "class", value: CSS.close } },
},
"--calcite-alert-close-icon-color-active": {
shadowSelector: `.${CSS.close}`,
targetProp: "color",
state: { press: { attribute: "class", value: CSS.close } },
},
"--calcite-alert-close-icon-color-focus": {
shadowSelector: `.${CSS.close}`,
targetProp: "color",
state: { focus: { attribute: "class", value: CSS.close } },
},
};
themed(
html`<calcite-alert open icon closable>
<div slot="title">Title Text</div>
<div slot="message">Message Text</div>
</calcite-alert>`,
tokens,
);
});
describe.skip("queued Alerts", () => {
/* Currently we cannot programmatically simulate a queued Alert in a `themed` test */
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me know if you'd like me to remove this block instead of using .skip() @alisonailea

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can achieve this by following this pattern.

WRT your original question, we can skip and create a follow-up issue to keep track of it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, I'll update in this PR.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated + merging 🎈

/* https://github.com/Esri/calcite-design-system/issues/9340 */
const tokens: ComponentTestTokens = {
"--calcite-alert-chip-background-color": {
shadowSelector: `.${CSS.container}`,
targetProp: "backgroundColor",
},
"--calcite-alert-chip-border-color": {
targetProp: "borderColor",
shadowSelector: `.${CSS.queueCount} >>> calcite-chip`,
},
"--calcite-alert-chip-corner-radius": {
targetProp: "borderRadius",
shadowSelector: `.${CSS.queueCount} >>> calcite-chip`,
},
"--calcite-alert-chip-text-color": {
targetProp: "color",
shadowSelector: `.${CSS.queueCount} >>> calcite-chip`,
},
};
themed(
html`<calcite-alert open icon closable>
<div slot="title">Title Text</div>
<div slot="message">Message Text</div>
</calcite-alert>`,
tokens,
);
});
});

it("renders default props when none are provided", async () => {
const page = await newE2EPage();
await page.setContent(`
Expand Down