Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT]: expr simplifier #3393

Merged
merged 15 commits into from
Dec 5, 2024

Merge branch 'main' of https://github.com/Eventual-Inc/Daft into expr…

ac0215a
Select commit
Loading
Failed to load commit list.
Merged

[FEAT]: expr simplifier #3393

Merge branch 'main' of https://github.com/Eventual-Inc/Daft into expr…
ac0215a
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Dec 3, 2024 in 0s

77.49% (+0.05%) compared to 75ad85a

View this Pull Request on Codecov

77.49% (+0.05%) compared to 75ad85a

Details

Codecov Report

Attention: Patch coverage is 86.56716% with 54 lines in your changes missing coverage. Please review.

Project coverage is 77.49%. Comparing base (75ad85a) to head (ac0215a).

Files with missing lines Patch % Lines
...lan/src/optimization/rules/simplify_expressions.rs 83.71% 36 Missing ⚠️
src/daft-logical-plan/src/treenode.rs 92.14% 11 Missing ⚠️
src/common/scan-info/src/test/mod.rs 0.00% 3 Missing ⚠️
src/daft-scan/src/anonymous.rs 0.00% 3 Missing ⚠️
daft/sql/sql_scan.py 50.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3393      +/-   ##
==========================================
+ Coverage   77.43%   77.49%   +0.05%     
==========================================
  Files         696      697       +1     
  Lines       84497    84924     +427     
==========================================
+ Hits        65429    65808     +379     
- Misses      19068    19116      +48     
Files with missing lines Coverage Δ
daft/delta_lake/delta_lake_scan.py 77.77% <100.00%> (+0.35%) ⬆️
daft/hudi/hudi_scan.py 87.95% <100.00%> (+0.29%) ⬆️
daft/iceberg/iceberg_scan.py 90.62% <100.00%> (+0.14%) ⬆️
daft/io/_generator.py 94.87% <100.00%> (+0.27%) ⬆️
daft/io/_lance.py 93.10% <100.00%> (+0.24%) ⬆️
src/common/scan-info/src/scan_operator.rs 50.00% <ø> (ø)
...rc/daft-logical-plan/src/optimization/optimizer.rs 98.87% <100.00%> (+0.03%) ⬆️
src/daft-scan/src/glob.rs 89.91% <100.00%> (+0.09%) ⬆️
src/daft-scan/src/python.rs 77.54% <100.00%> (+0.55%) ⬆️
daft/sql/sql_scan.py 25.89% <50.00%> (+0.35%) ⬆️
... and 4 more

... and 4 files with indirect coverage changes