Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT]: expr simplifier #3393

Merged
merged 15 commits into from
Dec 5, 2024

Merge branch 'main' of https://github.com/Eventual-Inc/Daft into expr…

ac0215a
Select commit
Loading
Failed to load commit list.
Merged

[FEAT]: expr simplifier #3393

Merge branch 'main' of https://github.com/Eventual-Inc/Daft into expr…
ac0215a
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch succeeded Dec 3, 2024 in 1s

86.56% of diff hit (target 77.43%)

View this Pull Request on Codecov

86.56% of diff hit (target 77.43%)

Annotations

Check warning on line 73 in daft/sql/sql_scan.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

daft/sql/sql_scan.py#L73 

Added line #L73 was not covered by tests

Check warning on line 102 in src/common/scan-info/src/test/mod.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/common/scan-info/src/test/mod.rs#L100-L102 

Added lines #L100 - L102 were not covered by tests

Check warning on line 31 in src/daft-logical-plan/src/optimization/rules/simplify_expressions.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/daft-logical-plan/src/optimization/rules/simplify_expressions.rs#L30-L31 

Added lines #L30 - L31 were not covered by tests

Check warning on line 37 in src/daft-logical-plan/src/optimization/rules/simplify_expressions.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/daft-logical-plan/src/optimization/rules/simplify_expressions.rs#L37 

Added line #L37 was not covered by tests

Check warning on line 59 in src/daft-logical-plan/src/optimization/rules/simplify_expressions.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/daft-logical-plan/src/optimization/rules/simplify_expressions.rs#L58-L59 

Added lines #L58 - L59 were not covered by tests

Check warning on line 71 in src/daft-logical-plan/src/optimization/rules/simplify_expressions.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/daft-logical-plan/src/optimization/rules/simplify_expressions.rs#L71 

Added line #L71 was not covered by tests

Check warning on line 85 in src/daft-logical-plan/src/optimization/rules/simplify_expressions.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/daft-logical-plan/src/optimization/rules/simplify_expressions.rs#L84-L85 

Added lines #L84 - L85 were not covered by tests

Check warning on line 108 in src/daft-logical-plan/src/optimization/rules/simplify_expressions.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/daft-logical-plan/src/optimization/rules/simplify_expressions.rs#L108 

Added line #L108 was not covered by tests

Check warning on line 117 in src/daft-logical-plan/src/optimization/rules/simplify_expressions.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/daft-logical-plan/src/optimization/rules/simplify_expressions.rs#L116-L117 

Added lines #L116 - L117 were not covered by tests

Check warning on line 122 in src/daft-logical-plan/src/optimization/rules/simplify_expressions.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/daft-logical-plan/src/optimization/rules/simplify_expressions.rs#L121-L122 

Added lines #L121 - L122 were not covered by tests

Check warning on line 178 in src/daft-logical-plan/src/optimization/rules/simplify_expressions.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/daft-logical-plan/src/optimization/rules/simplify_expressions.rs#L178 

Added line #L178 was not covered by tests

Check warning on line 183 in src/daft-logical-plan/src/optimization/rules/simplify_expressions.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/daft-logical-plan/src/optimization/rules/simplify_expressions.rs#L183 

Added line #L183 was not covered by tests

Check warning on line 203 in src/daft-logical-plan/src/optimization/rules/simplify_expressions.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/daft-logical-plan/src/optimization/rules/simplify_expressions.rs#L203 

Added line #L203 was not covered by tests

Check warning on line 205 in src/daft-logical-plan/src/optimization/rules/simplify_expressions.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/daft-logical-plan/src/optimization/rules/simplify_expressions.rs#L205 

Added line #L205 was not covered by tests

Check warning on line 211 in src/daft-logical-plan/src/optimization/rules/simplify_expressions.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/daft-logical-plan/src/optimization/rules/simplify_expressions.rs#L210-L211 

Added lines #L210 - L211 were not covered by tests

Check warning on line 227 in src/daft-logical-plan/src/optimization/rules/simplify_expressions.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/daft-logical-plan/src/optimization/rules/simplify_expressions.rs#L226-L227 

Added lines #L226 - L227 were not covered by tests

Check warning on line 245 in src/daft-logical-plan/src/optimization/rules/simplify_expressions.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/daft-logical-plan/src/optimization/rules/simplify_expressions.rs#L245 

Added line #L245 was not covered by tests

Check warning on line 250 in src/daft-logical-plan/src/optimization/rules/simplify_expressions.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/daft-logical-plan/src/optimization/rules/simplify_expressions.rs#L250 

Added line #L250 was not covered by tests

Check warning on line 263 in src/daft-logical-plan/src/optimization/rules/simplify_expressions.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/daft-logical-plan/src/optimization/rules/simplify_expressions.rs#L262-L263 

Added lines #L262 - L263 were not covered by tests

Check warning on line 268 in src/daft-logical-plan/src/optimization/rules/simplify_expressions.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/daft-logical-plan/src/optimization/rules/simplify_expressions.rs#L268 

Added line #L268 was not covered by tests

Check warning on line 270 in src/daft-logical-plan/src/optimization/rules/simplify_expressions.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/daft-logical-plan/src/optimization/rules/simplify_expressions.rs#L270 

Added line #L270 was not covered by tests

Check warning on line 287 in src/daft-logical-plan/src/optimization/rules/simplify_expressions.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/daft-logical-plan/src/optimization/rules/simplify_expressions.rs#L287 

Added line #L287 was not covered by tests

Check warning on line 301 in src/daft-logical-plan/src/optimization/rules/simplify_expressions.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/daft-logical-plan/src/optimization/rules/simplify_expressions.rs#L301 

Added line #L301 was not covered by tests

Check warning on line 307 in src/daft-logical-plan/src/optimization/rules/simplify_expressions.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/daft-logical-plan/src/optimization/rules/simplify_expressions.rs#L307 

Added line #L307 was not covered by tests

Check warning on line 321 in src/daft-logical-plan/src/optimization/rules/simplify_expressions.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/daft-logical-plan/src/optimization/rules/simplify_expressions.rs#L320-L321 

Added lines #L320 - L321 were not covered by tests
View more details on Codecov