Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Terminate nodes instead of stopping them #3427

Merged
merged 2 commits into from
Nov 26, 2024
Merged

Conversation

raunakab
Copy link
Contributor

Overview

Nodes were being stopped and saved for future re-use purposes. This PR turns off caching by settings cache_stopped_nodes to false. This tells ray to shut down the nodes when ray down ... is invoked.

@raunakab raunakab requested a review from jaychia November 25, 2024 23:47
@raunakab raunakab marked this pull request as ready for review November 25, 2024 23:47
@github-actions github-actions bot added the bug Something isn't working label Nov 25, 2024
- removed duplicated "ray" instance in the name
Copy link

codspeed-hq bot commented Nov 25, 2024

CodSpeed Performance Report

Merging #3427 will improve performances by 11.99%

Comparing bug/terminate-nodes (a318ca5) with main (fa1d9d7)

Summary

⚡ 1 improvements
✅ 16 untouched benchmarks

Benchmarks breakdown

Benchmark main bug/terminate-nodes Change
test_iter_rows_first_row[100 Small Files] 364.1 ms 325.1 ms +11.99%

Copy link

codecov bot commented Nov 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.46%. Comparing base (fa1d9d7) to head (a318ca5).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3427      +/-   ##
==========================================
- Coverage   77.35%   76.46%   -0.90%     
==========================================
  Files         684      684              
  Lines       83637    85410    +1773     
==========================================
+ Hits        64694    65305     +611     
- Misses      18943    20105    +1162     

see 19 files with indirect coverage changes

@raunakab raunakab merged commit 8bdd9ec into main Nov 26, 2024
45 checks passed
@raunakab raunakab deleted the bug/terminate-nodes branch November 26, 2024 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants