Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(optimizer): Implement greedy join reordering #3538

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Cleanup

c77c3d1
Select commit
Loading
Failed to load commit list.
Open

feat(optimizer): Implement greedy join reordering #3538

Cleanup
c77c3d1
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Dec 11, 2024 in 0s

77.72% (+0.03%) compared to 4567601

View this Pull Request on Codecov

77.72% (+0.03%) compared to 4567601

Details

Codecov Report

Attention: Patch coverage is 94.10029% with 20 lines in your changes missing coverage. Please review.

Project coverage is 77.72%. Comparing base (4567601) to head (c77c3d1).
Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
...src/optimization/rules/reorder_joins/join_graph.rs 93.27% 15 Missing ⚠️
...imization/rules/reorder_joins/greedy_join_order.rs 95.23% 5 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3538      +/-   ##
==========================================
+ Coverage   77.69%   77.72%   +0.03%     
==========================================
  Files         710      714       +4     
  Lines       86896    87389     +493     
==========================================
+ Hits        67513    67923     +410     
- Misses      19383    19466      +83     
Files with missing lines Coverage Δ
src/common/scan-info/src/test/mod.rs 41.30% <100.00%> (+3.94%) ⬆️
src/daft-logical-plan/src/test/mod.rs 100.00% <100.00%> (ø)
src/daft-physical-plan/src/test/mod.rs 100.00% <100.00%> (ø)
...imization/rules/reorder_joins/greedy_join_order.rs 95.23% <95.23%> (ø)
...src/optimization/rules/reorder_joins/join_graph.rs 95.46% <93.27%> (-2.51%) ⬇️

... and 21 files with indirect coverage changes