Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(optimizer): Implement greedy join reordering #3538

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Cleanup

c77c3d1
Select commit
Loading
Failed to load commit list.
Open

feat(optimizer): Implement greedy join reordering #3538

Cleanup
c77c3d1
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch succeeded Dec 11, 2024 in 1s

94.10% of diff hit (target 77.69%)

View this Pull Request on Codecov

94.10% of diff hit (target 77.69%)

Annotations

Check warning on line 98 in src/daft-logical-plan/src/optimization/rules/reorder_joins/greedy_join_order.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/daft-logical-plan/src/optimization/rules/reorder_joins/greedy_join_order.rs#L96-L98 

Added lines #L96 - L98 were not covered by tests

Check warning on line 105 in src/daft-logical-plan/src/optimization/rules/reorder_joins/greedy_join_order.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/daft-logical-plan/src/optimization/rules/reorder_joins/greedy_join_order.rs#L105 

Added line #L105 was not covered by tests

Check warning on line 139 in src/daft-logical-plan/src/optimization/rules/reorder_joins/greedy_join_order.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/daft-logical-plan/src/optimization/rules/reorder_joins/greedy_join_order.rs#L139 

Added line #L139 was not covered by tests

Check warning on line 81 in src/daft-logical-plan/src/optimization/rules/reorder_joins/join_graph.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/daft-logical-plan/src/optimization/rules/reorder_joins/join_graph.rs#L75-L81 

Added lines #L75 - L81 were not covered by tests

Check warning on line 86 in src/daft-logical-plan/src/optimization/rules/reorder_joins/join_graph.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/daft-logical-plan/src/optimization/rules/reorder_joins/join_graph.rs#L85-L86 

Added lines #L85 - L86 were not covered by tests

Check warning on line 98 in src/daft-logical-plan/src/optimization/rules/reorder_joins/join_graph.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/daft-logical-plan/src/optimization/rules/reorder_joins/join_graph.rs#L98 

Added line #L98 was not covered by tests

Check warning on line 189 in src/daft-logical-plan/src/optimization/rules/reorder_joins/join_graph.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/daft-logical-plan/src/optimization/rules/reorder_joins/join_graph.rs#L189 

Added line #L189 was not covered by tests

Check warning on line 254 in src/daft-logical-plan/src/optimization/rules/reorder_joins/join_graph.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/daft-logical-plan/src/optimization/rules/reorder_joins/join_graph.rs#L254 

Added line #L254 was not covered by tests

Check warning on line 453 in src/daft-logical-plan/src/optimization/rules/reorder_joins/join_graph.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/daft-logical-plan/src/optimization/rules/reorder_joins/join_graph.rs#L451-L453 

Added lines #L451 - L453 were not covered by tests
View more details on Codecov