Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added note hit sound effects (associated PR) #36

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Added note hit sound effects (associated PR) #36

wants to merge 3 commits into from
+19 −0

Conversation

FlooferLand
Copy link

@FlooferLand FlooferLand commented Jun 24, 2024 •
edited
Loading

This PR adds 3 sound note hit/click sound effects for normal gameplay.
These are for PR Funkin#2793

  • one is a hit sound I think originated from osu that for some reason every single rhythm game I've played uses (appears to be public domain as I've heard it in several games)
  • one is a ping pong sound effect I got from FreeSound that I edited, licensed under public domain
  • one is an EQ'd vine boom

originally #28 but I done goofed up

@FlooferLand FlooferLand mentioned this pull request Jun 24, 2024
Closed
@EliteMasterEric EliteMasterEric added status: reviewing internally Cannot be approved; under continuing review and quality assurance testing status: pending triage The bug or PR has not been reviewed yet. and removed status: reviewing internally Cannot be approved; under continuing review and quality assurance testing labels Jul 9, 2024
@AbnormalPoof AbnormalPoof added type: enhancement Provides an enhancement or new feature. size: small A small pull request with 10 or fewer changes status: pending pull request Has a PR which resolves it that is pending review. and removed status: pending triage The bug or PR has not been reviewed yet. labels Jan 22, 2025
@FlooferLand
Merge branch 'FunkinCrew:main' into hitsounds
96e4d77
@FlooferLand
Update note sounds and 'how to' guide
a0e5066 
Changed the note sounds and the structure of the assets for the rewrite of the previous hit sounds / note effects PR
@FlooferLand FlooferLand mentioned this pull request Feb 6, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
size: small A small pull request with 10 or fewer changes status: pending pull request Has a PR which resolves it that is pending review. type: enhancement Provides an enhancement or new feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@FlooferLand @EliteMasterEric @AbnormalPoof