-
Notifications
You must be signed in to change notification settings - Fork 759
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2-1 jobs skill rebalance (2018 patch/Renewal) #3223
Merged
MishimaHaruna
merged 21 commits into
HerculesWS:rebalance
from
guilherme-gm:old-job-rebalances-2
Apr 30, 2024
Merged
2-1 jobs skill rebalance (2018 patch/Renewal) #3223
MishimaHaruna
merged 21 commits into
HerculesWS:rebalance
from
guilherme-gm:old-job-rebalances-2
Apr 30, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guilherme-gm
force-pushed
the
old-job-rebalances-2
branch
2 times, most recently
from
August 5, 2023 18:38
137decb
to
2529e22
Compare
3 tasks
guilherme-gm
force-pushed
the
old-job-rebalances-2
branch
from
October 26, 2023 23:13
2529e22
to
ec870ec
Compare
guilherme-gm
force-pushed
the
old-job-rebalances-2
branch
from
January 7, 2024 17:35
ec870ec
to
c51c5d3
Compare
guilherme-gm
force-pushed
the
old-job-rebalances-2
branch
from
February 10, 2024 00:44
c51c5d3
to
13fb77a
Compare
- Area of effect: 3x3 -> 5x5 centered on target - Number of hits changed - 2-handed weapons: number of hits depend on number of targets - 1 target: 2 hits - 2 / 3 targets: 3 hits - 4 or more targets: 4 hits - other weapons: 2 hits - Variable cast time removed - Knockback increased: 1 cell -> 5 cells - 1 second cooldown added - After using the skill, caster can't switch weapons for 1 second - Gutterline feature removed From massive skills rebalance (1st/2nd/transclass) (2018.10.31)
- Change damage type: Short range physical -> Long range physical - Damage formula changed - Remove variable cast time - Add 0.5s delay after skill - Adds 1 second cooldown. - SP consumption increased: 12 -> 24. - After using the skill, caster can't switch weapons for 1 second From massive skills rebalance (1st/2nd/transclass) (2018.10.31)
- Gives additional 10% of ASPD (as equipment ASPD) - Now gives HIT +(2 * SkillLevel) - Now gives CRIT +(2 + SkillLevel) From massive skills rebalance (1st/2nd/transclass) (2018.10.31)
- Fixed and variable casttime removed - Added Cooldown of 0.5s From massive skills rebalance (1st/2nd/transclass) (2018.10.31)
- Gives additional ASPD +10% to caster and party members (as Equip ASPD) - Added HIT +(5 + 3 * SkillLevel) effect to caster and party members From massive skills rebalance (1st/2nd/transclass) (2018.10.31)
- Weapon destruction chance removed - Party members bonus changed based on skill level: 5% / 5% / 10% / 10% / 15% From massive skills rebalance (1st/2nd/transclass) (2018.10.31)
- Attack motion removed - Damage formula changed - Skill now does 50% more damage if target has less than 50% HP - Skill modifier is no longer halved when Enchant Deadly Poison is active - Global delay reduced: 2s -> 0.5s - 1s cooldown added From massive skills rebalance (1st/2nd/transclass) (2018.10.31)
- Damage formula changed - Explosion delay changed - Cooldown changed - Red Gemstone requirement removed - Explosion damage no longer splits between targets From massive skills rebalance (1st/2nd/transclass) (2018.10.31)
- Damage formula changed - Old: (100 ~ 330)% x 4 waves (10 hits each) - New: [400 + (Skill Level x 100)]% x 1 wave (20 hits) - Fixed casting time changed - Old: [2.48 - (Skill Level × 0.08)] seconds - New: 1.5 seconds at all skill levels - Variable casting time changed - Old: [9.92 - (Skill Level × 0.32)] seconds - New: [6.5 - (Skill Level × 0.2)] seconds - Global delay of skills reduced - Old: 5 seconds at all skill levels - New: 1 second at all skill levels - 5 seconds cooldown added - Chance of causing blind effect increased From massive skills rebalance (1st/2nd/transclass) (2018.10.31)
- Fixed casting time reduced - Old: 2.4 seconds at all skill levels - New: 1.5 seconds at all skill levels - Variable casting time reduced - Old: 9.6 seconds at all skill levels - New: 6.3 seconds at all skill levels - Global delay of skills reduced - Old: 2 ~ 7 seconds - New: 1 second at all skill levels - Cooldown added: [2 + (Skill Level x 0.5)] seconds From massive skills rebalance (1st/2nd/transclass) (2018.10.31)
- Fixed casting time changed - Old: [0.8 + (Skill Level * 0.16)] seconds - New: 1.5 seconds at all skill levels - Variable casting time changed - Old: [3.2 + (Skill Level * 0.64)] seconds - New: [4.3 + (Skill Level * 0.2)] seconds - Global delay of skills reduced - Old: 5 seconds at all skill levels - New: 1 second at all skill levels - 6 seconds cooldown added - Damage formula changed - Old: (100 + 40 * Skill Level)% MATK - New: (70 + 50 * Skill Level)% MATK From massive skills rebalance (1st/2nd/transclass) (2018.10.31)
- Fixed casting time changed - Old: [0.32 + (Skill Level × 0.08)] seconds - New: 0.5 seconds at all skill levels - Variable casting time changed - Old: [1.28 + (Skill Level × 0.32)] seconds - New: [1.8 + (Skill Level × 0.2)] seconds From massive skills rebalance (1st/2nd/transclass) (2018.10.31)
- Damage formula changed - Old: 100% per hit - New: 200% per hit - Fixed casting time changed - Old: (Skill Level x 0.112) seconds - New: 0.2 + (Skill Level x 0.2) seconds - Variable casting time changed - Old: (Skill Level x 0.448) seconds - New: 0.7 + (Skill Level x 0.5) seconds - Global delay of skills reduced - Old: 0.8 + (Skill Level x 0.2) seconds - New: 0.9 + (Skill Level x 0.1) seconds From massive skills rebalance (1st/2nd/transclass) (2018.10.31)
- Fixed casting time changed - Old: (Skill Level x 0.16) seconds - New: 0.8 seconds at all skill levels - Variable casting time changed - Old: (Skill Level x 0.64) seconds - New: 0.9 + (Skill Level x 0.2) seconds - Global delay of skills reduced - Old: 1 second at all skill levels - New: 0.5 seconds at all skill levels From massive skills rebalance (1st/2nd/transclass) (2018.10.31)
- Fixed casting time reduced: 3s -> 1s - Variable casting time reduced: 12s -> 4s - Global delay of skills reduced: 4s -> 1s - Cooldown added: 6s - Skill now deals damage to monsters of all race monsters (instead of only Undead property and Demon race monsters) - Skill now deals additional 30% damage per hits to monsters with: - Demon race - Shadow property - Undead race or property From massive skills rebalance (1st/2nd/transclass) (2018.10.31)
- Also gives CRI +(SkillLevel) when equipped with Maces From massive skills rebalance (1st/2nd/transclass) (2018.10.31)
- Now affects all nearby party members (Range: 18 cells) - Now casts on Self instead of Target - Effect reduced: 15%/30%/45% -> 10%/15%/20% cast time reduction - Duration changed: - Old: 30s/20s/10s or when you cast a skill - New: 60s (no longer ends when you cast a skill) - SP cost increased: 8 SP -> 45/57/69 - 0.5s fixed casting time added - 1s variable casting time added - Global delay of skills reduced: 2s -> 1s - 30s cooldown added From massive skills rebalance (1st/2nd/transclass) (2018.10.31)
- Now affects all nearby party members (Rangee: 18 cells) - Now casts on Self instead of Target - Effect changed: - Old: ATK +(5 x SkillLevel) - New: ATK/MATK +(5 x SkillLevel) - Lower level buffs does not replace an active, higher level, one - SP cost increased: - Old: 10 + (Skill Level x 3) - New: 56 + (Skill Level x 3) - Duration increased: 60s -> 120s - Fixed casting time added: 0.5s - Variable casting time added: 1s - Global delay reduced: 3s -> 1s - Cooldown added: 30s From massive skills rebalance (1st/2nd/transclass) (2018.10.31)
- Fixed casting time reduced: 1s -> 0.3s - Variable casting time added: 0.5s From massive skills rebalance (1st/2nd/transclass) (2018.10.31)
- Damage formula changed - Auto Blitz Beat no longer splits the damage among multiple targets From massive skills rebalance (1st/2nd/transclass) (2018.10.31)
guilherme-gm
force-pushed
the
old-job-rebalances-2
branch
from
April 7, 2024 23:23
13fb77a
to
8963880
Compare
MishimaHaruna
approved these changes
Apr 30, 2024
MishimaHaruna
added a commit
that referenced
this pull request
May 1, 2024
Signed-off-by: Haru <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Prelude
Draft Reason
This PR by itself is ready and I don't think there will be further changes, unless someone finds an issue or a review asks for some change.
BUT, the rebalance in main official servers came at once, so I believe the right thing to do is to merge this PR together with the rest of the rebalance (that will be in other PRs).
So I will keep this as draft for now, but feel free to give an early review :)
Changes Proposed
Introduces the rebalance of the 2-1 jobs skills. This change affects Renewal-only.
On official servers this came along with rebalances of 1st, 2nd jobs and transclass too. I am working in additional PRs for the 2-2 and bard/dancer, being in separate PRs in order to keep those PRs in a reasonable size.
The implementation in this PR is based on kRO and kRO zero patch notes, iRO Wiki, rAthena and divine pride info, along with some in-game testing. I can't say everything is 100% accurate because there were discrepancies between different sources, and I could not test everything in kRO, but should be quite close.
I won't list all the changes in the PR description, but it may be checked in each commit text. Also, the commits are in the same order as they appear in the references below.
Affected jobs/skills
Also, on a side note, I fixed a missing constant in db/constants.conf
References:
Issues addressed:
Part of #2727