ToMayaMeshConverter: Revert "ToMayaMeshConverter : No longer set normals" #1430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisc-lee
force-pushed
the
revertNotSetNormalsForMesh
branch
5 times, most recently
from
d15b7d7
to
a510744
Compare
…rmals" Reverts changes to no longer set normals when reading from a Cortex object to Maya mesh since by not reading the normals, we don't take into account the difference between face and vertex normals meaning Maya may not recompute the normals as expected. Also, SCCs published from outside Maya are also likely to be read into Maya with different than expected normals.
ivanimanishi
force-pushed
the
revertNotSetNormalsForMesh
branch
from
d6017e4
to
e1ee2c8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts #1386 since not setting the normals is causing more problems than it solves. I have also added a small change to the gitignore to ignore all
sconsdblitefiles.Related Issues
Checklist