feat: cursor pagination #537
Conversation
WalkthroughThe change updates the branch variable in the proto generation script. Specifically, the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
| @@ -3,7 +3,7 @@ BUILD_DIR=$ROOT_DIR/gen | |||
| PROTO_DIR=$ROOT_DIR/proto | |||
| TS_OUTPUT_DIR=$ROOT_DIR/proto-ts | |||
| TS_STUB_DIR=$ROOT_DIR/stub | |||
| injective_indexer_branch=dev | |||
| injective_indexer_branch=f/add-explorer-txs-v2-messages-logs | |||
There was a problem hiding this comment.
💡 Codebase verification
Action Required: Update Branch Variable Quoting
The shell script still sets the branch variable unquoted and uses it unquoted in the git clone command. To prevent potential word splitting or globbing issues—especially given that the branch name contains a slash—the variable should be quoted both at assignment and during usage. For example:
-
Change
injective_indexer_branch=f/add-explorer-txs-v2-messages-logs
to
injective_indexer_branch="f/add-explorer-txs-v2-messages-logs" -
Update the git clone command to use quotes:
git clone https://github.com/InjectiveLabs/injective-indexer.git $BUILD_DIR -b "$injective_indexer_branch" --depth 1 --single-branch > /dev/null
Please confirm that the specified branch exists on the remote repository and contains the expected proto definitions.
🔗 Analysis chain
Updated Branch Variable & Quoting Suggestions
The branch variable injective_indexer_branch has been updated to f/add-explorer-txs-v2-messages-logs. Please confirm that this branch exists on the remote repository and contains the expected proto definitions needed for the new features (e.g., cursor pagination).
Additionally, for robustness in shell parsing—especially since the branch name includes a slash—it’s a good idea to quote the assignment and its later usage. For example, you could update the code as follows:
-injective_indexer_branch=f/add-explorer-txs-v2-messages-logs
+injective_indexer_branch="f/add-explorer-txs-v2-messages-logs"And ensure that the branch variable is used safely in the git clone command (line 27):
- -b $injective_indexer_branch
+ -b "$injective_indexer_branch"This will help prevent any issues related to word splitting or unintentional globbing.
I'll start by gathering more context on the file by showing its full contents to verify the branch variable assignment and its usage. This will help confirm whether the variable is used with proper quoting in the git clone command and elsewhere.
🏁 Scripts executed
The following scripts were executed for the analysis:
Error: No shell scripts found
Script:
#!/bin/bash
echo "Contents of proto/indexer/gen.sh:"
cat proto/indexer/gen.sh
Length of output: 3848
Summary by CodeRabbit