Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: cursor pagination #537

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

feat: cursor pagination #537

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion proto/indexer/gen.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ BUILD_DIR=$ROOT_DIR/gen
PROTO_DIR=$ROOT_DIR/proto
TS_OUTPUT_DIR=$ROOT_DIR/proto-ts
TS_STUB_DIR=$ROOT_DIR/stub
injective_indexer_branch=dev
injective_indexer_branch=f/add-explorer-txs-v2-messages-logs
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codebase verification

Action Required: Update Branch Variable Quoting

The shell script still sets the branch variable unquoted and uses it unquoted in the git clone command. To prevent potential word splitting or globbing issues—especially given that the branch name contains a slash—the variable should be quoted both at assignment and during usage. For example:

  • Change
    injective_indexer_branch=f/add-explorer-txs-v2-messages-logs
    to
    injective_indexer_branch="f/add-explorer-txs-v2-messages-logs"

  • Update the git clone command to use quotes:
    git clone https://github.com/InjectiveLabs/injective-indexer.git $BUILD_DIR -b "$injective_indexer_branch" --depth 1 --single-branch > /dev/null

Please confirm that the specified branch exists on the remote repository and contains the expected proto definitions.

🔗 Analysis chain

Updated Branch Variable & Quoting Suggestions

The branch variable injective_indexer_branch has been updated to f/add-explorer-txs-v2-messages-logs. Please confirm that this branch exists on the remote repository and contains the expected proto definitions needed for the new features (e.g., cursor pagination).

Additionally, for robustness in shell parsing—especially since the branch name includes a slash—it’s a good idea to quote the assignment and its later usage. For example, you could update the code as follows:

-injective_indexer_branch=f/add-explorer-txs-v2-messages-logs
+injective_indexer_branch="f/add-explorer-txs-v2-messages-logs"

And ensure that the branch variable is used safely in the git clone command (line 27):

- -b $injective_indexer_branch
+ -b "$injective_indexer_branch"

This will help prevent any issues related to word splitting or unintentional globbing.

I'll start by gathering more context on the file by showing its full contents to verify the branch variable assignment and its usage. This will help confirm whether the variable is used with proper quoting in the git clone command and elsewhere.

🏁 Scripts executed

The following scripts were executed for the analysis:

Error: No shell scripts found

Script:

#!/bin/bash
echo "Contents of proto/indexer/gen.sh:"
cat proto/indexer/gen.sh

Length of output: 3848


# remove old gen
rm -rf $BUILD_DIR
Expand Down