chore: use eslint-fix-utils for element and property removals

[JoshuaKGoldberg]

PR Checklist

• Addresses an existing open issue: fixes 🛠 Tooling: Extract element/property removal to a shared package #747
• That issue was marked as status: accepting prs
• Steps in CONTRIBUTING.md were taken

Overview

Uses the exported APIs added in JoshuaKGoldberg/eslint-fix-utils@6bf5c33.

@michaelfaith I'd love to get your input on this: how does the API feel to you? If you think they should be changed drastically -here and/or in the other repo- I'm definitely up for iterating on them. 🙂

The build failures can be ignored, they're some problem in eslint-fix-utils that I haven't dug into yet. Blocked on: JoshuaKGoldberg/eslint-fix-utils#7 ✅ [email protected] should work now.

💖

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.82%. Comparing base (e57765b) to head (6af7b1e).
Report is 2 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #750      +/-   ##
==========================================
- Coverage   97.88%   97.82%   -0.06%     
==========================================
  Files          19       19              
  Lines        1180     1148      -32     
  Branches      142      140       -2     
==========================================
- Hits         1155     1123      -32     
  Misses         25       25              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[michaelfaith]

It definitely saved a fair amount of code in the cast of no-redundant-files, but it didn't really do anything to help us in unique-dependencies. It prevented us from taking advantage of the fact that you can assume the redundant dependency will not be the last element, and thus will always have a comma token after. So it ends up being a wash, in terms of value for that one.

As far as the api surface itself, it seems reasonable from the usage side.

[JoshuaKGoldberg]

Cool thanks! I'll go ahead and push this all through then. Agreed it's a little unfortunate to lose some of the nice optimizations in unique-dependencies. IME the cost of a few token lookups is never really relevant, so I don't mind too much.

[michaelfaith]

Looks good. Nice to see the cleanup it allowed for.

[michaelfaith]

Nice to be able also use this on the new rule too!

[github-actions]

🎉 This is included in version v0.21.1 🎉

The release is available on:

• GitHub releases
• npm package (@latest dist-tag)

Cheers! 📦🚀