Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update glmnet to use latest source from R package #2028

Merged
merged 4 commits into from
Nov 1, 2020

Conversation

JackDunnNZ
Copy link
Contributor

Ref JuliaStats/GLMNet.jl#46

The current glmnet build uses an older version of glmnet from 2014 that was copied into the GLMNet repo a long time ago, and this changes to build from the current R package source instead.

There are a couple of issues where I need some help:

  • the original glmnet build was given version 5, because the file was named glmnet5.f90 with no version info in the the file other than a datestamp. I figured it would make sense to sync the version to the tagged version of the R package, but the problem is that the most recent tag is currently v4.0.2, so there is the chance for a v5 conflict in future. I'd appreciate input on how to best solve this.
  • there is a warning about no license file being present. The license is GPLv2, but many R packages only specify the choice of license in their DESCRIPTION file rather than including a separate and complete license file. What is the best way to resolve this?

G/glmnet/build_tarballs.jl Outdated Show resolved Hide resolved
Comment on lines +27 to +30
flags="${flags} -fPIC";
fi
if [[ ${target} != aarch64* ]] && [[ ${target} != arm* ]]; then
flags="${flags} -m${nbits}"
flags="${flags} -m${nbits}";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why? 😅

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lol I didn't see this, I think it must have been added when I pasted the old script into the wizard 😅

Can remove if you like

G/glmnet/build_tarballs.jl Outdated Show resolved Hide resolved
@giordano
Copy link
Member

giordano commented Nov 1, 2020

the original glmnet build was given version 5, because the file was named glmnet5.f90 with no version info in the the file other than a datestamp. I figured it would make sense to sync the version to the tagged version of the R package, but the problem is that the most recent tag is currently v4.0.2, so there is the chance for a v5 conflict in future. I'd appreciate input on how to best solve this.

In the future we're going to separate the version number of the JLL package from that of the upstream project, so you'll be able to generate glmnet_jll v6 corresponding to the upstream version 5, in case that's necessary. However we still need to iron out the details of this, for the time being we stick to following the upstream version.

@giordano giordano merged commit 66a2b1c into JuliaPackaging:master Nov 1, 2020
@JackDunnNZ
Copy link
Contributor Author

Thanks for the help @giordano!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants