-
Notifications
You must be signed in to change notification settings - Fork 572
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update glmnet to use latest source from R package #2028
Conversation
flags="${flags} -fPIC"; | ||
fi | ||
if [[ ${target} != aarch64* ]] && [[ ${target} != arm* ]]; then | ||
flags="${flags} -m${nbits}" | ||
flags="${flags} -m${nbits}"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why? 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lol I didn't see this, I think it must have been added when I pasted the old script into the wizard 😅
Can remove if you like
Co-authored-by: Mosè Giordano <[email protected]>
Co-authored-by: Mosè Giordano <[email protected]>
In the future we're going to separate the version number of the JLL package from that of the upstream project, so you'll be able to generate |
Thanks for the help @giordano! |
Ref JuliaStats/GLMNet.jl#46
The current glmnet build uses an older version of glmnet from 2014 that was copied into the GLMNet repo a long time ago, and this changes to build from the current R package source instead.
There are a couple of issues where I need some help:
glmnet5.f90
with no version info in the the file other than a datestamp. I figured it would make sense to sync the version to the tagged version of the R package, but the problem is that the most recent tag is currently v4.0.2, so there is the chance for a v5 conflict in future. I'd appreciate input on how to best solve this.